mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jan.dakinevich@virtuozzo.com
Cc: linux-kernel@vger.kernel.org, den@virtuozzo.com,
	khorenko@virtuozzo.com, pabeni@redhat.com,
	viro@zeniv.linux.org.uk, axboe@kernel.dk, hare@suse.com,
	kgraul@linux.ibm.com, kyeongdon.kim@lge.com, tglx@linutronix.de,
	netdev@vger.kernel.org
Subject: Re: [PATCH] af_unix: utilize skb's fragment list for sending large datagrams
Date: Thu, 22 Aug 2019 12:04:21 -0700 (PDT)	[thread overview]
Message-ID: <20190822.120421.71092037400077946.davem@davemloft.net> (raw)
In-Reply-To: <1566470311-4089-1-git-send-email-jan.dakinevich@virtuozzo.com>

From: Jan Dakinevich <jan.dakinevich@virtuozzo.com>
Date: Thu, 22 Aug 2019 10:38:39 +0000

> However, paged part can not exceed MAX_SKB_FRAGS * PAGE_SIZE, and large
> datagram causes increasing skb's data buffer. Thus, if any user-space
> program sets send buffer (by calling setsockopt(SO_SNDBUF, ...)) to
> maximum allowed size (wmem_max) it becomes able to cause any amount
> of uncontrolled high-order kernel allocations.

So?  You want huge SKBs you get the high order allocations, seems
rather reasonable to me.

SKBs using fragment lists are the most difficult and cpu intensive
geometry for an SKB to have and we should avoid using it where
feasible.

I don't want to apply this, sorry.

  reply	other threads:[~2019-08-22 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 10:38 Jan Dakinevich
2019-08-22 19:04 ` David Miller [this message]
2019-08-24 20:38   ` Denis Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822.120421.71092037400077946.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=axboe@kernel.dk \
    --cc=den@virtuozzo.com \
    --cc=hare@suse.com \
    --cc=jan.dakinevich@virtuozzo.com \
    --cc=kgraul@linux.ibm.com \
    --cc=khorenko@virtuozzo.com \
    --cc=kyeongdon.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®