From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=CHARSET_FARAWAY_HEADER, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EEFC3A5A1 for ; Thu, 22 Aug 2019 23:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E810021744 for ; Thu, 22 Aug 2019 23:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388447AbfHVXXR (ORCPT ); Thu, 22 Aug 2019 19:23:17 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50512 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394362AbfHVXXM (ORCPT ); Thu, 22 Aug 2019 19:23:12 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E1BAF1539D836; Thu, 22 Aug 2019 16:23:10 -0700 (PDT) Date: Thu, 22 Aug 2019 16:23:10 -0700 (PDT) Message-Id: <20190822.162310.1544602687585865172.davem@davemloft.net> To: Markus.Elfring@web.de Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, allison@lohutok.net, lkml@metux.net, gregkh@linuxfoundation.org, gustavo@embeddedor.com, lukas@wunner.de, mkl@pengutronix.de, sean@geanix.com, tglx@linutronix.de, houweitaoo@gmail.com, wg@grandegger.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] can: Delete unnecessary checks before the macro call =?iso-2022-jp?B?GyRCIUgbKEJkZXZfa2ZyZWVfc2tiGyRCIUkbKEI=?= From: David Miller In-Reply-To: <27674907-fd2a-7f0c-84fd-d8b5124739a9@web.de> References: <27674907-fd2a-7f0c-84fd-d8b5124739a9@web.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Aug 2019 16:23:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 21 Aug 2019 21:30:11 +0200 > From: Markus Elfring > Date: Wed, 21 Aug 2019 21:16:15 +0200 > > The dev_kfree_skb() function performs also input parameter validation. > Thus the test around the shown calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.