From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AC9C3A5A4 for ; Fri, 23 Aug 2019 12:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 914DA2173E for ; Fri, 23 Aug 2019 12:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393201AbfHWMqO (ORCPT ); Fri, 23 Aug 2019 08:46:14 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5209 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388016AbfHWMqO (ORCPT ); Fri, 23 Aug 2019 08:46:14 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id EFD9016D994DD546A2AB; Fri, 23 Aug 2019 20:46:10 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Fri, 23 Aug 2019 20:46:03 +0800 From: YueHaibing To: , , , CC: , , YueHaibing Subject: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE Date: Fri, 23 Aug 2019 20:45:53 +0800 Message-ID: <20190823124553.19364-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If WATCHDOG_CORE is not set, build fails: drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6': drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device' Add WATCHDOG_CORE Kconfig dependency to fix this. Reported-by: Hulk Robot Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support") Signed-off-by: YueHaibing --- drivers/rtc/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 25af63d..9dce7dc 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -886,6 +886,8 @@ config RTC_DRV_DS3232_HWMON config RTC_DRV_PCF2127 tristate "NXP PCF2127" depends on RTC_I2C_AND_SPI + depends on WATCHDOG + select WATCHDOG_CORE help If you say yes here you get support for the NXP PCF2127/29 RTC chips with integrated quartz crystal for industrial applications. -- 2.7.4