From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Dmitry Vyukov <dvyukov@google.com>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCHv2] lib/test_kasan: add roundtrip tests
Date: Sat, 24 Aug 2019 13:30:53 -0700 [thread overview]
Message-ID: <20190824133053.aa5c6393815a5cb55dbdb8a4@linux-foundation.org> (raw)
In-Reply-To: <20190823104107.GA55480@lakrids.cambridge.arm.com>
On Fri, 23 Aug 2019 11:41:08 +0100 Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > /*
> >
> > which is really kinda wrong. We should strictly include linux/io.h for
> > things like virt_to_phys().
> >
> > So I think I'll stick with v1 plus my fixlet:
> >
> > --- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-checkpatch-fixes
> > +++ a/lib/test_kasan.c
> > @@ -18,8 +18,8 @@
> > #include <linux/slab.h>
> > #include <linux/string.h>
> > #include <linux/uaccess.h>
> > +#include <linux/io.h>
> >
> > -#include <asm/io.h>
> > #include <asm/page.h>
> >
> > /*
> >
>
> Assuming that you mean *v3* with that fix, that looks good to me!
Yes, that's what we have.
prev parent reply other threads:[~2019-08-24 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 16:14 Mark Rutland
2019-08-19 17:25 ` Andrey Ryabinin
2019-08-22 23:48 ` Andrew Morton
2019-08-23 10:41 ` Mark Rutland
2019-08-24 20:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824133053.aa5c6393815a5cb55dbdb8a4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®