From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA43C3A59F for ; Tue, 27 Aug 2019 01:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86F152173E for ; Tue, 27 Aug 2019 01:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566869837; bh=9vRfG2MIh0GfanQEmqv1QvA+MIKQYxd5YRT6jcYiI4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y8F4jr2pey95A1S58P5irmCYJNAW6qFz5Fse9bi7IBG9aDcxw2++AnYzy7dNlQlRn +nQPqiE2CazMyLc+lZtMg0B8W0bpvKQy36jo6szKI1WXQA0uzxH6U23HSy9Ih4L7RJ asXNyvAzG/n2IzAV+ZGwg6pnpKfG9rlHol8Lcn0U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728895AbfH0BhQ (ORCPT ); Mon, 26 Aug 2019 21:37:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:50396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728841AbfH0BhN (ORCPT ); Mon, 26 Aug 2019 21:37:13 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F4CB21872; Tue, 27 Aug 2019 01:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566869832; bh=9vRfG2MIh0GfanQEmqv1QvA+MIKQYxd5YRT6jcYiI4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NeBgT9RAsf2/i3YkcZKuftgjJx+b/gRjFhx6ijKv2BENzc0tnSegKRvkWh4/fVkc1 I/tnL2I41i2d0a6DNmQCYc7YclccLxa28G5tev1D5k/tGuCnd4V0WFjDCwyuZQoAOk ffkRSbiV8jIZsuhwl6OqyHJutta0zyp6g6+f9Fm8= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter Subject: [PATCH 10/33] perf augmented_raw_syscalls: Postpone tmp map lookup to after pid_filter Date: Mon, 26 Aug 2019 22:36:11 -0300 Message-Id: <20190827013634.3173-11-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190827013634.3173-1-acme@kernel.org> References: <20190827013634.3173-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo No sense in doing that lookup before figuring out if it will be used, i.e. if the pid is being filtered that tmp space lookup will be useless. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-o74yggieorucfg4j74tb6rta@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/examples/bpf/augmented_raw_syscalls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/examples/bpf/augmented_raw_syscalls.c b/tools/perf/examples/bpf/augmented_raw_syscalls.c index b85b177c6726..0a8d217d65c7 100644 --- a/tools/perf/examples/bpf/augmented_raw_syscalls.c +++ b/tools/perf/examples/bpf/augmented_raw_syscalls.c @@ -250,13 +250,13 @@ int sys_enter(struct syscall_enter_args *args) struct syscall *syscall; int key = 0; + if (pid_filter__has(&pids_filtered, getpid())) + return 0; + augmented_args = bpf_map_lookup_elem(&augmented_args_tmp, &key); if (augmented_args == NULL) return 1; - if (pid_filter__has(&pids_filtered, getpid())) - return 0; - probe_read(&augmented_args->args, sizeof(augmented_args->args), args); /* -- 2.21.0