From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E9CC3A59F for ; Tue, 27 Aug 2019 01:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A8A7217F5 for ; Tue, 27 Aug 2019 01:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566869849; bh=H9EbqBnwIZezyKkpEqZLoVVjIR3m2WWP0OVEGXntGpE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xbIOUSzKWaKCQBW6HbtnjaOQzP5xx+azUwiStPvSVtJ5LwyzTW0oJZRkTdspTvDmv dZfdSdWrNb2J1And9zWST0ctmnyLjRlfMYXGFgdx9hXCZ+fwfliY597EPo3Y6I6pk8 5LK7mayrqgHYmktprcTA2m0DGghtTdueZ/RjufE0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728983AbfH0Bh2 (ORCPT ); Mon, 26 Aug 2019 21:37:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:50598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728958AbfH0BhY (ORCPT ); Mon, 26 Aug 2019 21:37:24 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E73B322CBB; Tue, 27 Aug 2019 01:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566869844; bh=H9EbqBnwIZezyKkpEqZLoVVjIR3m2WWP0OVEGXntGpE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bfxxjs4k9/3V8d/4OlwmnKZcjOuTGsukTR+BE8g3/LgEcI6XF3dLxmRdepJ/kXx7z 4epr/41PPc1HbcXS8eb3sHj13ZvD7BuV153HNlDxCKaVRci6dz0Ks0VjFgcEZNmqWy z3eoOWJnBXnu9RoLYfk5hhnqunCwyeYgGbZjWplk= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andi Kleen , Arnaldo Carvalho de Melo Subject: [PATCH 14/33] perf report: Use timestamp__scnprintf_nsec() for time sort key Date: Mon, 26 Aug 2019 22:36:15 -0300 Message-Id: <20190827013634.3173-15-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190827013634.3173-1-acme@kernel.org> References: <20190827013634.3173-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Use timestamp__scnprintf_nsec() to print nanoseconds for the time sort key, instead of open coding. Signed-off-by: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190823210338.12360-1-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/sort.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index c522bdde3f71..83eb3fa6f941 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -670,17 +670,11 @@ sort__time_cmp(struct hist_entry *left, struct hist_entry *right) static int hist_entry__time_snprintf(struct hist_entry *he, char *bf, size_t size, unsigned int width) { - unsigned long secs; - unsigned long long nsecs; char he_time[32]; - nsecs = he->time; - secs = nsecs / NSEC_PER_SEC; - nsecs -= secs * NSEC_PER_SEC; - if (symbol_conf.nanosecs) - snprintf(he_time, sizeof he_time, "%5lu.%09llu: ", - secs, nsecs); + timestamp__scnprintf_nsec(he->time, he_time, + sizeof(he_time)); else timestamp__scnprintf_usec(he->time, he_time, sizeof(he_time)); -- 2.21.0