From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26883C3A5A3 for ; Tue, 27 Aug 2019 08:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3F1221881 for ; Tue, 27 Aug 2019 08:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566894250; bh=F2EeM65Vw9QXowD/5k6epy+05mZQDWiPim2ChYemKAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WXvPdDgs3oBlC6dtW+HTqQ+9+puBIsLYSnPbPcqqaFs4dahZhebFF8dNSHlzKOrvb OGBNB+o7QRvJY0frSsHlENXY5hZ6MVWeVZugT6QLGzEjc5acgQ2dhX3EQxPfYHvWmq yU6JEVbc0BbAlutxKfEtigD+edYXEBg5GGLM0ErY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729805AbfH0IYJ (ORCPT ); Tue, 27 Aug 2019 04:24:09 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51040 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728976AbfH0IYI (ORCPT ); Tue, 27 Aug 2019 04:24:08 -0400 Received: by mail-wm1-f66.google.com with SMTP id v15so2104889wml.0; Tue, 27 Aug 2019 01:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vjcjSeCevbHEiiIy79EbgY2nEsyBXssjOQgmLoyTyCY=; b=V+tpn3RtcsLU1B1PVUCBuFlt7KWVheNM/LfR/1S+zRKFo6UPy2Mi4eBMWHFNzgAp5m NYePQN5L1EZ7Lpxrl33nFyLWyHDYogJTezoAIDRNofrOgSluXg41d2ONwLOpbqaAavkB Bm3ELBFOM5C1/QnnONC0+EdkdZbN2aywnm4GezmuUJvGbvt/KGPz+KxmgQptwTvm1ZbL dyFC6iUDg0pYgta90+NNMFKoycPUKbA+NFdlglFUPpWFRNZcXoMZvX+uQCjkHPvpY6vk smOu/9nXSK9mOPasJNhpev5/bzqdEsgZo41mVwPeLgbExzLQFePFujhUrqih3uBlrWH4 eQTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=vjcjSeCevbHEiiIy79EbgY2nEsyBXssjOQgmLoyTyCY=; b=mkKLBnKBCJ81WJLPvmFoDCh2EZRnHE8jO20MsuvMFh+s5SSjQEt8ixcx8QEOa9aAYv h0B7ks0CRrVXs+Q3f4P+Afm7+gYUW/3Z6wcwt0XqcKmeCcbYvnQS5rbfS5uqGHdGPqil gOPkRDtelTkeK7ciJCb/A2uVYXDONH9ikU0xFtbcZ+oDhWOExxcs12n4QSasTJW6g98l CCmGwl/bjRZZIeBIEBn0BHYRAyNKpwdIbEhv7sS0j0c9GHgkMJ3Ixhfw7TjwUnm5yEsy orUy6mxTMBaRc5e5mRJG/BWXZ7M5tpvLzgxBegWq+oV+YH540W0JtjvKEXvJOA0rCoxt alNw== X-Gm-Message-State: APjAAAXAeCMHTK05mM9d5Mliwa30fOH4IfaR9bAXs1yfyKDBv75INtTy gsCBfGCUBSuKFqb0xxI9D/A= X-Google-Smtp-Source: APXvYqy9kOVG5T7VK0SQ1saYsd37E2xZfKg6cgI+3cxVqiudSnCKKzuKHUftMUvrzfXGA579EQsboQ== X-Received: by 2002:a1c:7611:: with SMTP id r17mr26707588wmc.117.1566894245355; Tue, 27 Aug 2019 01:24:05 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id g65sm3031208wma.21.2019.08.27.01.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2019 01:24:04 -0700 (PDT) Date: Tue, 27 Aug 2019 10:24:02 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Thomas Gleixner , Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andi Kleen , Benjamin Peterson , "Gustavo A . R . Silva" , James Clark , Souptick Joarder , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL] perf/core improvements and fixes Message-ID: <20190827082402.GA83092@gmail.com> References: <20190827013634.3173-1-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190827013634.3173-1-acme@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Hi Ingo/Thomas, > > Please consider pulling, > > Best regards, > > - Arnaldo > > Test results at the end of this message, as usual. > > The following changes since commit 39152ee51b77851689f9b23fde6f610d13566c39: > > perf/x86/intel/pt: Get rid of reverse lookup table for ToPA (2019-08-26 12:00:16 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-5.4-20190826 > > for you to fetch changes up to 74a1e863eb73dcc9f069b671dfb40650f3832116: > > perf evsel: Rename perf_missing_features::bpf_event to ::bpf (2019-08-26 19:39:11 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > perf report: > > Andi Kleen: > > - Make --ns time sort key output column wide enough for nanoseconds. > > perf script: > > Gustavo A. R. Silva: > > - Fix memory leaks in list_scripts() > > perf tests: > > James Clark: > > - Fixes hang in zstd compression test by changing the source of random data. > > perf trace: > > Arnaldo Carvalho de Melo: > > - augmented_raw_syscalls.c BPF helper improvements. > > Benjamin Peterson: > > - Fix off-by-one error in ioctl cmd->string table. > > libperf: > > Jiri Olsa: > > - Move most PERF_RECORD_ structs to perf/event.h. > > headers: > > Arnaldo Carvalho de Melo: > > - Move cacheline related routines to separate source files. > > - Move record_opts and other record declarations to separate files. > > - Explicitly add some more needed headers here and there. > > Souptick Joarder: > > - Remove some duplicate include directives. > > Signed-off-by: Arnaldo Carvalho de Melo > > ---------------------------------------------------------------- > Andi Kleen (2): > perf report: Use timestamp__scnprintf_nsec() for time sort key > perf report: Fix --ns time sort key output > > Arnaldo Carvalho de Melo (15): > perf cpumap: No need to include perf.h, ditch it > perf stat: Remove needless headers from stat.h > perf record: Move record_opts and other record decls out of perf.h > perf cacheline: Move cacheline related routines to separate files > perf srcline: Add missing srcline.h header to files needing its defs > perf sort: Remove needless headers from sort.h, provide fwd struct decls > perf augmented_raw_syscalls: Rename augmented_filename to augmented_arg > perf augmented_raw_syscalls: Postpone tmp map lookup to after pid_filter > perf augmented_raw_syscalls: Introduce helper to get the scratch space > perf augmented_raw_syscalls: Reduce perf_event_output() boilerplate > libperf: Rename the PERF_RECORD_ structs to have a "perf" suffix > perf tools: Rename perf_event::ksymbol_event to perf_event::ksymbol > perf tools: Rename perf_event::bpf_event to perf_event::bpf > perf tool: Rename perf_tool::bpf_event to bpf > perf evsel: Rename perf_missing_features::bpf_event to ::bpf > > Benjamin Peterson (1): > perf trace beauty ioctl: Fix off-by-one error in cmd->string table > > Gustavo A. R. Silva (1): > perf script: Fix memory leaks in list_scripts() > > James Clark (1): > perf tests: Fixes hang in zstd compression test by changing the source of random data > > Jiri Olsa (12): > libperf: Add PERF_RECORD_MMAP 'struct mmap_event' to perf/event.h > libperf: Add PERF_RECORD_MMAP2 'struct mmap2_event' to perf/event.h > libperf: Add PERF_RECORD_COMM 'struct comm_event' to perf/event.h > libperf: Add PERF_RECORD_NAMESPACES 'struct namespaces_event' to perf/event.h > libperf: Add PERF_RECORD_FORK 'struct fork_event' to perf/event.h > libperf: Add PERF_RECORD_LOST 'struct lost_event' to perf/event.h > libperf: Add PERF_RECORD_LOST_SAMPLES 'struct lost_samples_event' to perf/event.h > libperf: Add PERF_RECORD_READ 'struct read_event' to perf/event.h > libperf: Add PERF_RECORD_THROTTLE 'struct throttle_event' to perf/event.h > libperf: Add PERF_RECORD_KSYMBOL 'struct ksymbol_event' to perf/event.h > libperf: Add PERF_RECORD_BPF_EVENT 'struct bpf_event' to perf/event.h > libperf: Add PERF_RECORD_SAMPLE 'struct sample_event' to perf/event.h > > Souptick Joarder (1): > perf tools: Remove duplicate headers > > tools/perf/arch/arm/util/cs-etm.c | 2 +- > tools/perf/arch/arm64/util/arm-spe.c | 1 + > tools/perf/arch/s390/util/auxtrace.c | 1 + > tools/perf/arch/x86/tests/perf-time-to-tsc.c | 2 + > tools/perf/arch/x86/util/intel-bts.c | 1 + > tools/perf/arch/x86/util/intel-pt.c | 3 +- > tools/perf/builtin-c2c.c | 1 + > tools/perf/builtin-diff.c | 2 + > tools/perf/builtin-record.c | 4 +- > tools/perf/builtin-report.c | 1 + > tools/perf/builtin-sched.c | 2 +- > tools/perf/builtin-script.c | 7 +- > tools/perf/builtin-stat.c | 2 +- > tools/perf/builtin-trace.c | 1 + > tools/perf/examples/bpf/augmented_raw_syscalls.c | 100 +++++++-------- > tools/perf/lib/include/perf/event.h | 112 ++++++++++++++++ > tools/perf/perf.h | 62 --------- > tools/perf/tests/backward-ring-buffer.c | 2 +- > tools/perf/tests/bpf.c | 1 + > tools/perf/tests/code-reading.c | 1 + > tools/perf/tests/keep-tracking.c | 1 + > tools/perf/tests/openat-syscall-tp-fields.c | 3 +- > tools/perf/tests/parse-no-sample-id-all.c | 4 +- > tools/perf/tests/perf-record.c | 2 +- > tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +- > tools/perf/tests/switch-tracking.c | 1 + > tools/perf/tests/task-exit.c | 1 + > tools/perf/trace/beauty/ioctl.c | 2 +- > tools/perf/ui/browsers/res_sample.c | 2 + > tools/perf/ui/browsers/scripts.c | 8 +- > tools/perf/ui/stdio/hist.c | 1 + > tools/perf/util/Build | 1 + > tools/perf/util/annotate.c | 2 + > tools/perf/util/auxtrace.c | 2 +- > tools/perf/util/bpf-event.c | 36 +++--- > tools/perf/util/bpf-event.h | 10 +- > tools/perf/util/cacheline.c | 26 ++++ > tools/perf/util/cacheline.h | 21 +++ > tools/perf/util/callchain.c | 1 + > tools/perf/util/cpumap.h | 2 - > tools/perf/util/data.c | 1 - > tools/perf/util/event.c | 35 +++-- > tools/perf/util/event.h | 149 +++++----------------- > tools/perf/util/evlist.c | 2 +- > tools/perf/util/evsel.c | 22 ++-- > tools/perf/util/evsel.h | 4 +- > tools/perf/util/get_current_dir_name.c | 1 - > tools/perf/util/hist.c | 5 +- > tools/perf/util/intel-bts.c | 2 +- > tools/perf/util/kvm-stat.h | 2 +- > tools/perf/util/machine.c | 25 ++-- > tools/perf/util/machine.h | 1 + > tools/perf/util/namespaces.c | 2 +- > tools/perf/util/namespaces.h | 4 +- > tools/perf/util/python.c | 58 ++++----- > tools/perf/util/record.c | 1 + > tools/perf/util/record.h | 74 +++++++++++ > tools/perf/util/session.c | 16 +-- > tools/perf/util/sort.c | 12 +- > tools/perf/util/sort.h | 27 +--- > tools/perf/util/stat-display.c | 1 - > tools/perf/util/stat.c | 1 + > tools/perf/util/stat.h | 7 +- > tools/perf/util/thread.c | 4 +- > tools/perf/util/thread.h | 4 +- > tools/perf/util/tool.h | 2 +- > tools/perf/util/top.h | 1 + > tools/perf/util/util.c | 20 --- > tools/perf/util/util.h | 1 - > 69 files changed, 493 insertions(+), 427 deletions(-) > create mode 100644 tools/perf/lib/include/perf/event.h > create mode 100644 tools/perf/util/cacheline.c > create mode 100644 tools/perf/util/cacheline.h > create mode 100644 tools/perf/util/record.h Pulled, thanks a lot Arnaldo! Ingo