From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A4C8C3A5A6 for ; Tue, 27 Aug 2019 18:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 243AA21881 for ; Tue, 27 Aug 2019 18:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566929603; bh=yYKB4kckHSdb+bVRQWSNHqQ5ZIn7P0u/JkfY8blA0gQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hL5b65PQBpIpu/8c14rhr9wAgeMRbnezVhslCJ1MGXmgXzOf5o3k/WubriEMxBtVO GrkJylkZgVIvAG7YYiJ2wpsvvNwHBsuRslwxy8OYtHt6UiHRW5AYhOINUVwvFz4k+4 LVXudk2mqckoKAOI7H33+rRC+3lwNFnfhBJGL+N0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730599AbfH0SNW (ORCPT ); Tue, 27 Aug 2019 14:13:22 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:41136 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728972AbfH0SNV (ORCPT ); Tue, 27 Aug 2019 14:13:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pkM+sr3lP0C6AVZjZJyAdt0csnEWF4HAF/OR4wC4dA8=; b=uYHaoADu28XXgB9P698M+li7O CrdLDtChW3Jn5eoz2w8zwlEeR5HItQbWbS4OX0UKL0Icx0dTDx4toEVQ41Op0k1ZGBCUt1mrPjGcW Bz70h6Z/RM/KhYR2EQNvIPZSVbiKln5iy7F6nc5/L/F21Yktvdq4M4ZbW7LigJXKM6CJs=; Received: from 92.41.142.151.threembb.co.uk ([92.41.142.151] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i2fy3-0000sz-A7; Tue, 27 Aug 2019 18:13:19 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 6E1B4D02CE6; Tue, 27 Aug 2019 19:13:18 +0100 (BST) Date: Tue, 27 Aug 2019 19:13:18 +0100 From: Mark Brown To: Vladimir Oltean Cc: linux-spi@vger.kernel.org, lkml , devicetree@vger.kernel.org, netdev , Rob Herring , Shawn Guo Subject: Re: [PATCH v2 5/5] ARM: dts: ls1021a-tsn: Use the DSPI controller in poll mode Message-ID: <20190827181318.GG23391@sirena.co.uk> References: <20190822211514.19288-1-olteanv@gmail.com> <20190822211514.19288-6-olteanv@gmail.com> <20190827180502.GF23391@sirena.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Qtzb1h6tVL0ohdDu" Content-Disposition: inline In-Reply-To: X-Cookie: Don't SANFORIZE me!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Qtzb1h6tVL0ohdDu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 27, 2019 at 09:06:14PM +0300, Vladimir Oltean wrote: > On Tue, 27 Aug 2019 at 21:05, Mark Brown wrote: > > On Mon, Aug 26, 2019 at 04:10:51PM +0300, Vladimir Oltean wrote: > > > I noticed you skipped applying this patch, and I'm not sure that Shawn > > > will review it/take it. > > > Do you have a better suggestion how I can achieve putting the DSPI > > > driver in poll mode for this board? A Kconfig option maybe? > > DT changes go through the relevant platform trees, not the > > subsystem trees, so it's not something I'd expect to apply. > But at least is it something that you expect to see done through a > device tree change? Well, it's not ideal - if it performs better all the time the driver should probably just do it unconditionally. If there's some threashold where it tends to perform better then the driver should check for that but IIRC it sounds like the interrupt just isn't at all helpful here. --Qtzb1h6tVL0ohdDu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1lcr0ACgkQJNaLcl1U h9DiNQf44uUy1o+vPwfy6IZd76tgLRc0F21kMaHMJBkX9RYaQ3/YV3E4t0iaFjE/ 3o4DF69ZkIXWQOirPQM73xvOUmU/06qCJCjU+QJAukVjKFdT2dgXLDBic+043CTR I0I3OZH8QJiFmPodSkHgFmI0mKIagD21X1187YWrKtZ5WJ8VzWaJS8IamAMKgj2+ hiNrp/TYthXpJ3MBoY8eYJVD+EuyqaDHkHoPE+2yYePl2YPmkjTwVjR1Mbge3Sbt pTFH4xoDnHTAiH6EYQI2YnpEKCUVK/FwK/lpCTBLUfUVhAuxJSGyqvHeSqYMDMJD HFuQ6G6plEMXcfwYUX5gStzzs8UE =pCt+ -----END PGP SIGNATURE----- --Qtzb1h6tVL0ohdDu--