From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E52C3A5A3 for ; Tue, 27 Aug 2019 19:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5E8A205C9 for ; Tue, 27 Aug 2019 19:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566935087; bh=qru5mwHq7JuS+Z7epM8v/WN+pkruuwtHlA8k2Xre/bU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hpkNUKGBIGF7jG4lm1w26wVC83/F5Sc6Hj6FFplryGy9Q2Zzlw4GzxpvX+GqmRACF 9rvO1+vpto91aV+SCTG2Sj79WyoLiiqaRkvDo0+Yswc5afAruCS1M6gPbrM+iO44Fr m9cCmkLniSTvdr9L8MkF10MhdtOC391Na1kYMbAk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730994AbfH0Toq (ORCPT ); Tue, 27 Aug 2019 15:44:46 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53516 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbfH0Top (ORCPT ); Tue, 27 Aug 2019 15:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZkyrTJsfOjFeT9DU9YWNBO4J5POV3kWv2nzxcp7HESs=; b=QtmmuBPjjKfKpMEpglfMXttTa faxnzfOuiy1GhBkPAlXWqwyaqvB8iSyPV8eJyN021MSTWTB1X4EoMc0Ql4JyUTxeXZFwq3CB7Zvbh EmGbT0/cfgk4Lh8BULMhrUeNbiZIldlkijPtXe/AKweP2SNN1XWe4t/n/voGUiZTlUJfE=; Received: from 188.28.18.107.threembb.co.uk ([188.28.18.107] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i2hOS-00018k-L3; Tue, 27 Aug 2019 19:44:40 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 7D13ED02CE6; Tue, 27 Aug 2019 20:44:37 +0100 (BST) Date: Tue, 27 Aug 2019 20:44:37 +0100 From: Mark Brown To: Jisheng Zhang Cc: Liam Girdwood , Rob Herring , Mark Rutland , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/8] regulator: add support for SY8824C regulator Message-ID: <20190827194437.GO23391@sirena.co.uk> References: <20190827163252.4982af95@xhacker.debian> <20190827163418.1a32fc48@xhacker.debian> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ch6x/diZ8cQC324S" Content-Disposition: inline In-Reply-To: <20190827163418.1a32fc48@xhacker.debian> X-Cookie: Don't SANFORIZE me!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ch6x/diZ8cQC324S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote: This looks mostly good and I'll apply it, a couple of small things though: > @@ -0,0 +1,192 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SY8824C regulator driver > + * Please send a patch which updates the entire comment block to be C++ style so it looks consistent. > +#define BUCK_EN (1 << 7) > +#define MODE (1 << 6) > + Please also add prefixes to these to namespace them, especially MODE is likely to collide with something later. --ch6x/diZ8cQC324S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1liCQACgkQJNaLcl1U h9C9rgf/Xy1nABMJdavfpBaTNK/T0dAqzeL4PbecKw+JWZ95N5qd8YzDvedjAyT1 ZZNNKYyF6i8+gLPjEs2h3CCLfZqnYMyGrNnLSOGzW9k/a0DtnLg8+4lIFdls9qKc CcZyOdp+UrPirPfxpjJCG4hvqXPfex1LNX0T7TU5XL84vPnFaq7LUM5l8bLW4QfQ xCTK4Fx1UzFGodW/24DpXvI1OI5suqnS2e+PtMPxM56sT8KgjE9Y/ZsGWUi//SLH ogxrcoA6YG49Y/JWd52cFGiFkLvkrkfPdnqLM+2XtpRSwItqOkdVFnQkIFEg8wQF KHNnU8/HPD+izR09pC/BF2AB4NgebQ== =Zq5D -----END PGP SIGNATURE----- --ch6x/diZ8cQC324S--