mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: rostedt@goodmis.org
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
	oss-drivers@netronome.com,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH 2/3] tracing: remove exported but unused trace_array_destroy()
Date: Tue, 27 Aug 2019 22:25:48 -0700	[thread overview]
Message-ID: <20190828052549.2472-3-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20190828052549.2472-1-jakub.kicinski@netronome.com>

trace_array_destroy() is an exported symbol, but not only
are there no in-tree callers, it doesn't actually have
a declaration in any header.

This fixes the "no previous prototype for" warning.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
 kernel/trace/trace.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 947ba433865f..4cd9855dcd88 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8438,25 +8438,6 @@ static int __remove_instance(struct trace_array *tr)
 	return 0;
 }
 
-int trace_array_destroy(struct trace_array *tr)
-{
-	int ret;
-
-	if (!tr)
-		return -EINVAL;
-
-	mutex_lock(&event_mutex);
-	mutex_lock(&trace_types_lock);
-
-	ret = __remove_instance(tr);
-
-	mutex_unlock(&trace_types_lock);
-	mutex_unlock(&event_mutex);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(trace_array_destroy);
-
 static int instance_rmdir(const char *name)
 {
 	struct trace_array *tr;
-- 
2.21.0


  parent reply	other threads:[~2019-08-28  5:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  5:25 [PATCH 0/3] tracing: fix minor build warnings Jakub Kicinski
2019-08-28  5:25 ` [PATCH 1/3] tracing: correct kdoc formats Jakub Kicinski
2019-08-28  5:25 ` Jakub Kicinski [this message]
2019-08-28  5:25 ` [PATCH 3/3] tracing: make trace_array_create() static Jakub Kicinski
2019-08-30 22:01 ` [PATCH 0/3] tracing: fix minor build warnings Steven Rostedt
2019-08-30 22:38   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828052549.2472-3-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oss-drivers@netronome.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®