From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A606C3A5A1 for ; Wed, 28 Aug 2019 06:42:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DEE822CF5 for ; Wed, 28 Aug 2019 06:42:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="LAGTZCbA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbfH1Gmi (ORCPT ); Wed, 28 Aug 2019 02:42:38 -0400 Received: from mail.skyhub.de ([5.9.137.197]:46808 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726154AbfH1Gmh (ORCPT ); Wed, 28 Aug 2019 02:42:37 -0400 Received: from zn.tnic (p200300EC2F0A5300695CBFF1DBB4ADA1.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5300:695c:bff1:dbb4:ada1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9F2F51EC0A9C; Wed, 28 Aug 2019 08:42:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1566974556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=q3SPVObGZs4wIn6VYQDUEo/svpxKkil+BKyip/LH4Ng=; b=LAGTZCbAMoDZ32+nudzNSSo+1vA2I9ouKsKgYn2PnmV2u1AxDuIkAR2Ej2dEci/roI750W lAgdfNenXYMDj/RoeoXvE7YIbFGrdRLWbUQaoKFRrn1dgQ+k0uWNM+S7pmiVdVdugPvZbu IpRxMZPJB37qx1fn/UpDzPsL7+bWMd4= Date: Wed, 28 Aug 2019 08:42:31 +0200 From: Borislav Petkov To: Cao jin Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, Dave Hansen Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro Message-ID: <20190828064231.GB4920@zn.tnic> References: <20190828061100.27032-1-caoj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190828061100.27032-1-caoj.fnst@cn.fujitsu.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 02:11:00PM +0800, Cao jin wrote: For the future: > Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro your subject needs to have a verb and start with a capital letter after the subsystem/path prefix. In this case, something like this, for example: Subject: [PATCH] x86/cpufeature: Explain the macro duplication > Help people to understand the author's intent of apparent duplication of > BUILD_BUG_ON_ZERO(NCAPINTS != n), which is hard to detect by eyes. > > CC: Dave Hansen > Suggested-by: Borislav Petkov > Signed-off-by: Cao jin > --- > Tried my best to describe it accurately, in case of any inaccuracy, feel > free to rephrase. Yap, I fixed it up. Thanks! -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.