From: Ming Lei <ming.lei@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
kbuild test robot <lkp@intel.com>,
Keith Busch <kbusch@kernel.org>,
Jon Derrick <jonathan.derrick@intel.com>
Subject: [PATCH] genirq/affinity: Fix build waring in __irq_build_affinity_masks
Date: Wed, 28 Aug 2019 16:58:15 +0800 [thread overview]
Message-ID: <20190828085815.19931-1-ming.lei@redhat.com> (raw)
When CONFIG_CPUMASK_OFFSTACK isn't enabled, 'cpumask_var_t' will be
defined as 'typedef struct cpumask cpumask_var_t[1]', so we can't
declare the argument of 'node_to_cpumask' as 'const cpumask_var_t *'
for alloc_nodes_vectors().
Fixes the following warning:
kernel/irq/affinity.c: In function '__irq_build_affinity_masks':
>> kernel/irq/affinity.c:287:31: warning: passing argument 2 of 'alloc_nodes_vectors' from incompatible pointer type
alloc_nodes_vectors(numvecs, node_to_cpumask, cpu_mask,
^
kernel/irq/affinity.c:128:13: note: expected 'const struct cpumask (*)[1]' but argument is of type 'struct cpumask (*)[1]'
static void alloc_nodes_vectors(unsigned int numvecs,
^
Fixes: b1a5a73e64e9 ("genirq/affinity: Spread vectors on node according to nr_cpu ratio")
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
kernel/irq/affinity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
index d905e844bf3a..4d89ad4fae3b 100644
--- a/kernel/irq/affinity.c
+++ b/kernel/irq/affinity.c
@@ -126,7 +126,7 @@ static int ncpus_cmp_func(const void *l, const void *r)
* for each node.
*/
static void alloc_nodes_vectors(unsigned int numvecs,
- const cpumask_var_t *node_to_cpumask,
+ cpumask_var_t *node_to_cpumask,
const struct cpumask *cpu_mask,
const nodemask_t nodemsk,
struct cpumask *nmsk,
--
2.20.1
next reply other threads:[~2019-08-28 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 8:58 Ming Lei [this message]
2019-08-28 10:22 ` [tip: irq/core] genirq/affinity: Remove const qualifier from node_to_cpumask argument tip-bot2 for Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828085815.19931-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®