From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: next-20190826 - objtool fails to build.
Date: Wed, 28 Aug 2019 10:10:04 -0500 [thread overview]
Message-ID: <20190828151003.3px5plk4tp2s5s5c@treble> (raw)
In-Reply-To: <133250.1566965715@turing-police>
On Wed, Aug 28, 2019 at 12:15:15AM -0400, Valdis Klētnieks wrote:
> OK. I'm mystified. next-20190806 built fine. -0818 and -0826 died a
> glorious death indeed. All 3 were build using the same Fedora Rawhide 9.1.1
> compiler (installed on July 30). 'git log -- tools/objtool' comes up empty.
>
> Local hack-around was to remove the -Werror from tools/objtool/Makefile
>
> Am particularly mystified by the errors on lines 808/809 - the same compiler that
> was happy with the same code in next-0806 is now upset. The others could possibly
> be a stray typedef in an include someplace, but those two errors have me stumped.
>
> For that matter, I'm not even seeing how -Wsign-compare was even getting set, given
> a command 'make' and not W=1 or W=2....
>
> (cue twilight zone theme)
Weird. I don't have access to Rawhide at the moment so I can't
recreate. It builds fine for me on Fedora 29.
But I don't see how those warnings could get enabled: -Wsign-compare
-Wunused-parameter.
Can you "make clean" and do "make V=1 tools/objtool" to show the actual
flags?
The reported warnings do seem reasonable though, maybe we should fix
them regardless and explicitly enable the warnings.
--
Josh
next prev parent reply other threads:[~2019-08-28 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 4:15 Valdis Klētnieks
2019-08-28 15:10 ` Josh Poimboeuf [this message]
2019-08-28 19:30 ` Valdis Klētnieks
2019-08-28 19:51 ` Josh Poimboeuf
2019-08-28 19:58 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828151003.3px5plk4tp2s5s5c@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®