From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F6EC3A59F for ; Thu, 29 Aug 2019 13:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B15282339E for ; Thu, 29 Aug 2019 13:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfH2Ncm (ORCPT ); Thu, 29 Aug 2019 09:32:42 -0400 Received: from mga05.intel.com ([192.55.52.43]:4996 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727066AbfH2Ncm (ORCPT ); Thu, 29 Aug 2019 09:32:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 06:32:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,443,1559545200"; d="scan'208";a="197806262" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 29 Aug 2019 06:32:40 -0700 From: Heikki Krogerus To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kbuild test robot , Dan Carpenter Subject: [PATCH v2] software node: Fix use of potentially uninitialized variables Date: Thu, 29 Aug 2019 16:32:39 +0300 Message-Id: <20190829133239.77541-1-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.23.0.rc1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org reported by smatch: drivers/base/swnode.c:656 software_node_find_by_name() error: uninitialized symbol 'swnode'. drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol 'swnode'. Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Heikki Krogerus --- Hi, I had separate patch for both errors in the first version. thanks, --- drivers/base/swnode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index ee2a405cca9a..a1f3f0994f9f 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(is_software_node); static struct swnode * software_node_to_swnode(const struct software_node *node) { - struct swnode *swnode; + struct swnode *swnode = NULL; struct kobject *k; if (!node) @@ -633,7 +633,7 @@ static const struct fwnode_operations software_node_ops = { const struct software_node * software_node_find_by_name(const struct software_node *parent, const char *name) { - struct swnode *swnode; + struct swnode *swnode = NULL; struct kobject *k; if (!name) -- 2.23.0.rc1