From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15B9C3A59F for ; Thu, 29 Aug 2019 16:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 767CF21874 for ; Thu, 29 Aug 2019 16:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567095483; bh=QOWOBP/IN2miDZCZXYZ5OXPPVxczIlcm/Ppdn547IM0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AhLoFBMH77/Mh+o29Kwdhqg4DB0kylUz+twwGdgD7kk/bezUAbYua32EGMIRKxnC1 OIDD0gLjeDj46/zry5ydRfwci6BNiNuABM2ch5VF7O4EY2llRjpOnL3f3R+AcxCD1r REFUIpdpxCsldOlE1vNhsoegbdvBfLZLTwic2V/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727673AbfH2QSC (ORCPT ); Thu, 29 Aug 2019 12:18:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:48798 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726728AbfH2QSC (ORCPT ); Thu, 29 Aug 2019 12:18:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 22AACAFF9; Thu, 29 Aug 2019 16:18:01 +0000 (UTC) Date: Thu, 29 Aug 2019 18:17:59 +0200 From: Michal Hocko To: Edward Chron Cc: Tetsuo Handa , Andrew Morton , Roman Gushchin , Johannes Weiner , David Rientjes , Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ivan Delalande Subject: Re: [PATCH 00/10] OOM Debug print selection and additional information Message-ID: <20190829161759.GK28313@dhcp22.suse.cz> References: <20190826193638.6638-1-echron@arista.com> <20190827071523.GR7538@dhcp22.suse.cz> <20190828065955.GB7386@dhcp22.suse.cz> <20190829071105.GQ28313@dhcp22.suse.cz> <297cf049-d92e-f13a-1386-403553d86401@i-love.sakura.ne.jp> <20190829115608.GD28313@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 29-08-19 08:03:19, Edward Chron wrote: > On Thu, Aug 29, 2019 at 4:56 AM Michal Hocko wrote: [...] > > Or simply provide a hook with the oom_control to be called to report > > without replacing the whole oom killer behavior. That is not necessary. > > For very simple addition, to add a line of output this works. Why would a hook be limited to small stuff? > It would still be nice to address the fact the existing OOM Report prints > all of the user processes or none. It would be nice to add some control > for that. That's what we did. TBH, I am not really convinced partial taks list is desirable nor easy to configure. What is the criterion? oom_score (with potentially unstable metric)? Rss? Something else? -- Michal Hocko SUSE Labs