From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE64CC3A5A3 for ; Thu, 29 Aug 2019 22:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C852D2080F for ; Thu, 29 Aug 2019 22:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728202AbfH2WXH (ORCPT ); Thu, 29 Aug 2019 18:23:07 -0400 Received: from mga06.intel.com ([134.134.136.31]:16742 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727912AbfH2WXG (ORCPT ); Thu, 29 Aug 2019 18:23:06 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 15:23:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,445,1559545200"; d="scan'208";a="182478350" Received: from friedlmi-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.54.26]) by fmsmga007.fm.intel.com with ESMTP; 29 Aug 2019 15:23:03 -0700 Date: Fri, 30 Aug 2019 01:23:01 +0300 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Alexey Klimov Subject: Re: [PATCH 2/2 v2] tpm_tis: override durations for STM tpm with firmware 1.2.8.28 Message-ID: <20190829222301.iqtttpzn2dgoyrze@linux.intel.com> References: <20190828004621.29050-1-jsnitsel@redhat.com> <20190828004621.29050-3-jsnitsel@redhat.com> <20190829144002.zhuqxnsswgl65pnm@linux.intel.com> <20190829202527.auyqek7yryuvaruk@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829202527.auyqek7yryuvaruk@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 01:25:27PM -0700, Jerry Snitselaar wrote: > On Thu Aug 29 19, Jarkko Sakkinen wrote: > > On Tue, Aug 27, 2019 at 05:46:21PM -0700, Jerry Snitselaar wrote: > > > There was revealed a bug in the STM TPM chipset used in Dell R415s. > > > Bug is observed so far only on chipset firmware 1.2.8.28 > > > (1.2 TPM, device-id 0x0, rev-id 78). After some number of > > > operations chipset hangs and stays in inconsistent state: > > > > > > tpm_tis 00:09: Operation Timed out > > > tpm_tis 00:09: tpm_transmit: tpm_send: error -5 > > > > > > Durations returned by the chip are the same like on other > > > firmware revisions but apparently with specifically 1.2.8.28 fw > > > durations should be reset to 2 minutes to enable tpm chip work > > > properly. No working way of updating firmware was found. > > > > > > This patch adds implementation of ->update_durations method > > > that matches only STM devices with specific firmware version. > > > > > > Cc: Peter Huewe > > > Cc: Jarkko Sakkinen > > > Cc: Jason Gunthorpe > > > Signed-off-by: Alexey Klimov > > > Signed-off-by: Jerry Snitselaar > > > --- > > > v2: Make suggested changes from Jarkko > > > - change struct field name to durations from durs > > > - formatting cleanups > > > - turn into void function like update_timeouts and > > > use chip->duration_adjusted to track whether adjustment occurred. > > > > The code repetition looks horrible so I wrote a patch that should help: > > > > https://patchwork.kernel.org/patch/11121475/ > > > > Read the remar that prepends the diffstat. > > > > /Jarkko > > LGTM, and testing it on a 1.2 tpm system here worked fine. You can add my > Reviewed-by and Tested-by. > > I have reworked this 2/2 patch to make use of these new structs and > pull the tpm1_getcap calls out of the for loop. So I will submit a v3 > to go on top of your patch. Add my patch to the patch set with the tags. /Jarkko