mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Shuah Khan <shuah.kh@samsung.com>
Subject: Re: [PATCH] tracing: silence noisy warnings about struct inode
Date: Sat, 31 Aug 2019 11:48:56 -0400	[thread overview]
Message-ID: <20190831114856.26b0a1d7@oasis.local.home> (raw)
In-Reply-To: <20190831114633.0ea3a8ca@oasis.local.home>

On Sat, 31 Aug 2019 11:46:33 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 29 Aug 2019 14:34:18 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix 30 warnings for missing "struct inode" declaration (like these) by
> > adding a forward reference for it.
> > These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
> >   CC      include/trace/events/iomap.h.s
> > 
> > ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>  

Hmm, I don't have this in my tree (I Cc'd Shuah, because I mistaken it as iommu.h.

Please send this to the appropriate maintainer that added this file.

-- Steve

> 
> Thanks!
> 
> -- Steve
> 
> > ---
> >  include/trace/events/iomap.h |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > --- linux-next-20190829.orig/include/trace/events/iomap.h
> > +++ linux-next-20190829/include/trace/events/iomap.h
> > @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
> >  		  __entry->length)
> >  )
> >  
> > +struct inode;
> > +
> >  #define DEFINE_PAGE_EVENT(name)		\
> >  DEFINE_EVENT(iomap_page_class, name,	\
> >  	TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \  
> 


      reply	other threads:[~2019-08-31 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 21:34 Randy Dunlap
2019-08-31 15:46 ` Steven Rostedt
2019-08-31 15:48   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190831114856.26b0a1d7@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=shuah.kh@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®