mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] reset: Remove copy'n'paste redundancy in the comments
Date: Mon, 2 Sep 2019 16:19:20 +0300	[thread overview]
Message-ID: <20190902131920.GK2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190819105252.81020-1-andriy.shevchenko@linux.intel.com>

On Mon, Aug 19, 2019 at 01:52:52PM +0300, Andy Shevchenko wrote:
> It seems the commit bb475230b8e5
> ("reset: make optional functions really optional")
> brought couple of redundant lines in the comments.
> 
> Drop them here.

Any comment on this?

> 
> Cc: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/reset/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 213ff40dda11..2badff33a0db 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -334,7 +334,6 @@ EXPORT_SYMBOL_GPL(reset_control_reset);
>   * internal state to be reset, but must be prepared for this to happen.
>   * Consumers must not use reset_control_reset on shared reset lines when
>   * reset_control_(de)assert has been used.
> - * return 0.
>   *
>   * If rstc is NULL it is an optional reset and the function will just
>   * return 0.
> @@ -393,7 +392,6 @@ EXPORT_SYMBOL_GPL(reset_control_assert);
>   * After calling this function, the reset is guaranteed to be deasserted.
>   * Consumers must not use reset_control_reset on shared reset lines when
>   * reset_control_(de)assert has been used.
> - * return 0.
>   *
>   * If rstc is NULL it is an optional reset and the function will just
>   * return 0.
> -- 
> 2.23.0.rc1
> 

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-09-02 13:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 10:52 Andy Shevchenko
2019-09-02 13:19 ` Andy Shevchenko [this message]
2019-09-02 14:04   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902131920.GK2680@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome