From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_ADSP_ALL, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F379C3A5A2 for ; Tue, 3 Sep 2019 18:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E462622CED for ; Tue, 3 Sep 2019 18:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbfICSMQ (ORCPT ); Tue, 3 Sep 2019 14:12:16 -0400 Received: from valentin-vidic.from.hr ([94.229.67.141]:55695 "EHLO valentin-vidic.from.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbfICSMP (ORCPT ); Tue, 3 Sep 2019 14:12:15 -0400 X-Virus-Scanned: Debian amavisd-new at valentin-vidic.from.hr Received: by valentin-vidic.from.hr (Postfix, from userid 1000) id E35E13A32A; Tue, 3 Sep 2019 20:12:08 +0200 (CEST) Date: Tue, 3 Sep 2019 20:12:08 +0200 From: Valentin =?utf-8?B?VmlkacSH?= To: Al Viro Cc: Valdis Kletnieks , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements Message-ID: <20190903181208.GA8469@valentin-vidic.from.hr> References: <20190903164732.14194-1-vvidic@valentin-vidic.from.hr> <20190903173249.GL1131@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903173249.GL1131@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0xFFFF) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? Sure, but maybe in a separate patch since TRUE/FALSE has more calls than just this. -- Valentin