From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78841C3A5A2 for ; Tue, 3 Sep 2019 16:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5060323711 for ; Tue, 3 Sep 2019 16:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730349AbfICQps (ORCPT ); Tue, 3 Sep 2019 12:45:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730079AbfICQpr (ORCPT ); Tue, 3 Sep 2019 12:45:47 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 568788553F; Tue, 3 Sep 2019 16:45:47 +0000 (UTC) Received: from gondolin (ovpn-116-176.ams2.redhat.com [10.36.116.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A2156012C; Tue, 3 Sep 2019 16:45:45 +0000 (UTC) Date: Tue, 3 Sep 2019 18:45:42 +0200 From: Cornelia Huck To: Halil Pasic Cc: Tony Krowiak , Harald Freudenberger , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , Christian Borntraeger Subject: Re: [PATCH 1/1] s390: vfio-ap: fix warning reset not completed Message-ID: <20190903184542.2d955111.cohuck@redhat.com> In-Reply-To: <20190903133618.9122-1-pasic@linux.ibm.com> References: <20190903133618.9122-1-pasic@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 03 Sep 2019 16:45:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Sep 2019 15:36:18 +0200 Halil Pasic wrote: "fix warning for not completed reset"? > The intention seems to be to warn once when we don't wait enough for the > reset to complete. Let's use the right retry counter to accomplish that > semantic. > > Signed-off-by: Halil Pasic > --- > drivers/s390/crypto/vfio_ap_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index 0604b49a4d32..5c0f53c6dde7 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -1143,7 +1143,7 @@ int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi, > msleep(20); > status = ap_tapq(apqn, NULL); > } > - WARN_ON_ONCE(retry <= 0); > + WARN_ON_ONCE(retry2 <= 0); > return 0; > case AP_RESPONSE_RESET_IN_PROGRESS: > case AP_RESPONSE_BUSY: Makes sense. Reviewed-by: Cornelia Huck