From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9D6C3A5A7 for ; Tue, 3 Sep 2019 19:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0071D22DCC for ; Tue, 3 Sep 2019 19:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567538133; bh=pxvNwkIYBpfP9P4oP2jtUCPh44W0Ug2Efjd0qnDRXdw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jTR22mzYPX2LFPC15+8iTHKzBGOa+mbAISkor9m9kymZBtUYb9MDGwz2McsrCTBps liDhcrs0cYs3S/mDKvVIsXR3QRicKKULvEGpXNTOuNairxR529IqG/uVIEI5sQ0HbS 2O/KdAlzjCVWyTvVJNBL0R559mTj4AebxMjHmdfc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfICTPc (ORCPT ); Tue, 3 Sep 2019 15:15:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:53954 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725882AbfICTPb (ORCPT ); Tue, 3 Sep 2019 15:15:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 363C0AF10; Tue, 3 Sep 2019 19:15:30 +0000 (UTC) Date: Tue, 3 Sep 2019 21:15:28 +0200 From: Michal Hocko To: Matthew Wilcox Cc: William Kucharski , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Dave Hansen , Song Liu , Bob Kasten , Mike Kravetz , Chad Mynhier , "Kirill A. Shutemov" , Johannes Weiner Subject: Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP Message-ID: <20190903191528.GC14028@dhcp22.suse.cz> References: <20190902092341.26712-1-william.kucharski@oracle.com> <20190902092341.26712-3-william.kucharski@oracle.com> <20190903121424.GT14028@dhcp22.suse.cz> <20190903122208.GE29434@bombadil.infradead.org> <20190903125150.GW14028@dhcp22.suse.cz> <20190903151015.GF29434@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903151015.GF29434@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-09-19 08:10:15, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 02:51:50PM +0200, Michal Hocko wrote: > > On Tue 03-09-19 05:22:08, Matthew Wilcox wrote: > > > On Tue, Sep 03, 2019 at 02:14:24PM +0200, Michal Hocko wrote: > > > > On Mon 02-09-19 03:23:41, William Kucharski wrote: > > > > > Add filemap_huge_fault() to attempt to satisfy page > > > > > faults on memory-mapped read-only text pages using THP when possible. > > > > > > > > This deserves much more description of how the thing is implemented and > > > > expected to work. For one thing it is not really clear to me why you > > > > need CONFIG_RO_EXEC_FILEMAP_HUGE_FAULT_THP at all. You need a support > > > > from the filesystem anyway. So who is going to enable/disable this > > > > config? > > > > > > There are definitely situations in which enabling this code will crash > > > the kernel. But we want to get filesystems to a point where they can > > > start working on their support for large pages. So our workaround is > > > to try to get the core pieces merged under a CONFIG_I_KNOW_WHAT_IM_DOING > > > flag and let people play with it. Then continue to work on the core > > > to eliminate those places that are broken. > > > > I am not sure I understand. Each fs has to opt in to the feature > > anyway. If it doesn't then there should be no risk of regression, right? > > I do not expect any fs would rush an implementation in while not being > > sure about the correctness. So how exactly does a config option help > > here. > > Filesystems won't see large pages unless they've opted into them. > But there's a huge amount of page-cache work that needs to get done > before this can be enabled by default. For example, truncate() won't > work properly. > > Rather than try to do all the page cache work upfront, then wait for the > filesystems to catch up, we want to get some basics merged. Since we've > been talking about this for so long without any movement in the kernel > towards actual support, this felt like a good way to go. > > We could, of course, develop the entire thing out of tree, but that's > likely to lead to pain and anguish. Then I would suggest mentioning all this in the changelog so that the overall intention is clear. It is also up to you fs developers to find a consensus on how to move forward. I have brought that up mostly because I really hate seeing new config options added due to shortage of confidence in the code. That really smells like working around standard code quality inclusion process. -- Michal Hocko SUSE Labs