From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48CCC3A5A2 for ; Tue, 3 Sep 2019 21:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C4B021897 for ; Tue, 3 Sep 2019 21:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HchqMEFk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726917AbfICVHn (ORCPT ); Tue, 3 Sep 2019 17:07:43 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46166 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbfICVHn (ORCPT ); Tue, 3 Sep 2019 17:07:43 -0400 Received: by mail-pf1-f193.google.com with SMTP id q5so3825425pfg.13 for ; Tue, 03 Sep 2019 14:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vC5iA0bQsbGKHyeKcPI7gPcJFZDzY4mLs43Aq/+9Tik=; b=HchqMEFk8+5F9xV5oyWGTZDa6C4y79p3FWN4sLDb/LwG1ZPoPyup9gXWI0jqKjpMPj IyTezlwsToG7IzfOKQkE0Kt/N4rij2tPUfTCBvk0IKQU9giEtoVGyQkThfIGhOH70fvv GJ6zQis/rr1HCRcQpf4VnzHhmPGJ6nZ35VBDN1egClJyM7U3aOxLn+ffGqU+MhD5iB1f NXqeDjORIQGx05GOnsGQ/jmft/IYLCyRB7GE5vpuAH4yAyFhxBhNYV4N9dPhIAM6RyFM wiNbs1P0+msoJL3uVw0cLE7D/4GxGdT0t3lvjFU51YIegtOMEm23p8YeIrLu0UNYy5f7 tcsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vC5iA0bQsbGKHyeKcPI7gPcJFZDzY4mLs43Aq/+9Tik=; b=DRRjADOeG+0E+KOB4Xd+oJQGS8SYADVpAHTfqX2aAWOWm57zTYg1p7UEABnSSsPV1c 0xeAtjsrzJrZh1bAygnCq8s7TYnkqm9jQewuD7kSozQeiWSWDWAkm9GBom/8YCXoM5bo tKsOSr4pjyLM5tBW+gYpkmt2AVLfxFAI/ZA9Muhvw5PiFqQs2fk+Kzovp5y5kGezLcd8 anMQ0RHoRk/jlsDrGj0XnP/dNhkA2AozQomjYBXir0AZxBCgyJKxx/101SZSNj0o1w5T YuzzVhzXe7ARtLi3Y4ozGyNjZJgmfz5cvBGLrAMkOloMtwG6zHdsnB5jL+4r0PkdvWFI YPVg== X-Gm-Message-State: APjAAAUOBKgzfGvv6c0j8cbBZaAcNpHZN41OT/K0Axe5kzzCi3Oo29Cs b+vU5XNg49sUTh0AWayI5XuDYA== X-Google-Smtp-Source: APXvYqxpWDYjlQ7HP5zqOy8oYtw2mwWvQ55CkeJud59Die7cmaNGXUSUGX0/WbXfo753JzRYQVkqGQ== X-Received: by 2002:a62:6045:: with SMTP id u66mr41471485pfb.261.1567544862502; Tue, 03 Sep 2019 14:07:42 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id k8sm15646806pgm.14.2019.09.03.14.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 14:07:41 -0700 (PDT) Date: Tue, 3 Sep 2019 14:07:39 -0700 From: Bjorn Andersson To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, Loic Pallardy , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] remoteproc: don't allow modular build Message-ID: <20190903210739.GW6167@minitux> References: <20190902200746.16185-1-hch@lst.de> <20190902200746.16185-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902200746.16185-4-hch@lst.de> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 02 Sep 13:07 PDT 2019, Christoph Hellwig wrote: > Remoteproc started using dma_declare_coherent_memory recently, which is > a bad idea from drivers, and the maintainers agreed to fix that. But > until that is fixed only allow building the driver built in so that we > can remove the dma_declare_coherent_memory export and prevent other > drivers from "accidentally" using it like remoteproc. Note that the > driver would also leak the declared coherent memory on unload if it > actually was built as a module at the moment. > > Signed-off-by: Christoph Hellwig Reviewed-by: Bjorn Andersson Please pick this together with the other patches. Regards, Bjorn > --- > drivers/remoteproc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index 28ed306982f7..94afdde4bc9f 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -2,7 +2,7 @@ > menu "Remoteproc drivers" > > config REMOTEPROC > - tristate "Support for Remote Processor subsystem" > + bool "Support for Remote Processor subsystem" > depends on HAS_DMA > select CRC32 > select FW_LOADER > -- > 2.20.1 >