From: Changbin Du <changbin.du@gmail.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Changbin Du <changbin.du@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
yamada.masahiro@socionext.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] genirq: move debugfs option to kernel hacking
Date: Wed, 4 Sep 2019 00:50:54 +0000 [thread overview]
Message-ID: <20190904005053.hnk3hh35vqagnikt@mail.google.com> (raw)
In-Reply-To: <20190901114936.5e2f3490@why>
On Sun, Sep 01, 2019 at 11:49:36AM +0100, Marc Zyngier wrote:
> On Sun, 1 Sep 2019 18:10:33 +0800
> Changbin Du <changbin.du@gmail.com> wrote:
>
> > On Sun, Sep 01, 2019 at 08:23:02AM +0200, Thomas Gleixner wrote:
> > > On Sun, 1 Sep 2019, Changbin Du wrote:
> > >
> > > > Just like the other generic debug options, move the irq one to
> > > > 'Kernel hacking' menu.
> > >
> > > Why?
> > >
> > > Kernel hacking is a inscrutable mess where you can waste a lot of time to
> > > find what you are looking for.
> > >
> > yes, the 'kernel hacking' menu has many items now and are not well structured.
> > Let me see if it can be improved.
> >
> > > If I want to debug interrupts then having the option right there where all
> > > other interrupt related configuration is makes tons of sense.
> > >
> > > I would be less opposed to this when the kernel hacking menu would be
> > > halfways well structured, but you just chose another random place for that
> > > option which is worse than what we have now.
> > >
> > We already have an irq debug option CONFIG_DEBUG_SHIRQ here. Maybe we can group
> > them into a submenu.
>
> DEBUG_SHIRQ is extremely different from GENERIC_IRQ_DEBUGFS. The former
> is a test option, verifying that endpoint drivers have a correct
> behaviour. The latter is a dump of the kernel internals, which is
> mostly for people dealing with the internals of the IRQ subsystem.
>
> Preserving this distinction between the users of the IRQ API on one
> side and the debugging of the IRQ subsystem on the other is important.
> Moving these two things close together could make it even more confusing
> for the users (who usually do not need to mess with the IRQ subsystem's
> internals...).
>
IMHO, these are two distinct irq *debug* options. If we prefer
preserving current position, please skip this patch. Thanks.
> Thanks,
>
> M.
> --
> Without deviation from the norm, progress is not possible.
--
Cheers,
Changbin Du
prev parent reply other threads:[~2019-09-04 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 3:55 Changbin Du
2019-09-01 6:23 ` Thomas Gleixner
2019-09-01 10:10 ` Changbin Du
2019-09-01 10:49 ` Marc Zyngier
2019-09-04 0:50 ` Changbin Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904005053.hnk3hh35vqagnikt@mail.google.com \
--to=changbin.du@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®