From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 129D1C3A59E for ; Wed, 4 Sep 2019 05:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6E2F206BB for ; Wed, 4 Sep 2019 05:15:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="XOb99Kzi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728068AbfIDFPw (ORCPT ); Wed, 4 Sep 2019 01:15:52 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36822 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfIDFPv (ORCPT ); Wed, 4 Sep 2019 01:15:51 -0400 Received: by mail-pf1-f195.google.com with SMTP id y22so6827044pfr.3 for ; Tue, 03 Sep 2019 22:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t927y1khlcFbJ5TIcMQsCQQZ5PjZ/jC3FUiyzaKm0xU=; b=XOb99KzijvQur9tAY1DhfKGGRZI7vtlx/Beim1yaYj/lpuRs6X1wfG9SDUGcST4Kdr a+fBPIJYJ50KoXBDStczwTkBSXlbivAmRKwnRoKtVCcJrC3FqAWx5jqMwqWmZpsyr6h4 khkJHK5GuH2aBTRCasn8yqND/okuCogJiSqkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=t927y1khlcFbJ5TIcMQsCQQZ5PjZ/jC3FUiyzaKm0xU=; b=dJhqGMSqdKDoahpW+tB/LLqKRr04iBCuGVaV5sFIkVTAbZ3VzmkqlaZYGKFsc8Ak2G N3+h/IzUr3LA3AFubHOo+v8auSR/JjXatGjo794CCgvK3h985fO4+wMWPVsH+TZf9VJ/ Hn+TDArcUKUIPwAnjjztKxot0KTTWsjHSBnYAYRapIWvcoEp3fO2BsuvNAahMHMR2PaY kr3MYAbccG8N+3hQ99fMcbeow7rnfa+atKWMBo1/7l/KvspD11tGA6zrRN1bI/NW4sw7 jdrnuq7MZCGn5TUYyQPyjmGffgwwdrPoYXh1qyNjLv9/+bZuQucweGC2ENjq5ACcSUHc 7ULg== X-Gm-Message-State: APjAAAWdGZ4UxUg3VRvmkLuL1P6qPkV14bI7qogH0d1xWVZ/FAckrcOa eWICU9yovUQLLku1fgcT96sgJQ== X-Google-Smtp-Source: APXvYqzugh5tH8AehCVMWStbl6p9lwVs92YQnW+2nHFZFgFsUosZZJUnfaS9trtUmXFIX8piXL4olw== X-Received: by 2002:aa7:870c:: with SMTP id b12mr5565098pfo.122.1567574151089; Tue, 03 Sep 2019 22:15:51 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id x11sm1566783pja.3.2019.09.03.22.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 22:15:50 -0700 (PDT) Date: Wed, 4 Sep 2019 01:15:49 -0400 From: Joel Fernandes To: Daniel Colascione Cc: Suren Baghdasaryan , LKML , Tim Murray , Carmen Jackson , Mayank Gupta , Steven Rostedt , Minchan Kim , Andrew Morton , kernel-team , "Aneesh Kumar K.V" , Dan Williams , Jerome Glisse , linux-mm , Matthew Wilcox , Michal Hocko , Ralph Campbell , Vlastimil Babka Subject: Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold Message-ID: <20190904051549.GB256568@google.com> References: <20190903200905.198642-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 09:51:20PM -0700, Daniel Colascione wrote: > On Tue, Sep 3, 2019 at 9:45 PM Suren Baghdasaryan wrote: > > > > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > > wrote: > > > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > > memory hogs. Several Android teams have been using this patch in various > > > kernel trees for half a year now. Many reported to me it is really > > > useful so I'm posting it upstream. > > It's also worth being able to turn off the per-task memory counter > caching, otherwise you'll have two levels of batching before the > counter gets updated, IIUC. I prefer to keep split RSS accounting turned on if it is available. I think discussing split RSS accounting is a bit out of scope of this patch as well. Any improvements on that front can be a follow-up. Curious, has split RSS accounting shown you any issue with this patch? thanks, - Joel