mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: Zhengjun Xing <zhengjun.xing@linux.intel.com>,
	mingo@redhat.com, tom.zanussi@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
Date: Wed, 4 Sep 2019 12:59:23 -0400	[thread overview]
Message-ID: <20190904125923.7b1e66b8@oasis.local.home> (raw)
In-Reply-To: <1567602838.13841.1.camel@kernel.org>

On Wed, 04 Sep 2019 08:13:58 -0500
Tom Zanussi <zanussi@kernel.org> wrote:

> Hi Steve,
> 
> On Wed, 2019-09-04 at 06:43 -0400, Steven Rostedt wrote:
> > On Fri, 12 Jul 2019 11:05:06 -0500
> > Tom Zanussi <zanussi@kernel.org> wrote:
> >   
> > > Hi Zhengjun,
> > > 
> > > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:  
> > > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> > > > parameter in some functions can be traced.
> > > > 
> > > > Prints the gfp flags as hex in addition to the human-readable
> > > > flag
> > > > string.  Example output:
> > > > 
> > > >   whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> > > > (GFP_ATOMIC|__GFP_ZERO)
> > > >     rcuc/0-11  [000] ...1 81.097555: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > >     rcuc/0-11  [000] ...1 81.583123: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > > 
> > > > Signed-off-by: Tom Zanussi <zanussi@kernel.org>  
> > 
> > Why is this Signed-off-by Tom? Tom, did you author part of this??
> >   
> 
> Yeah, I added the part that prints the flag names.
> 

OK, I'll comment that in the patch change log.

Thanks!

-- Steve

      reply	other threads:[~2019-09-04 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  1:53 Zhengjun Xing
2019-07-12 16:05 ` Tom Zanussi
2019-08-13  1:04   ` Xing Zhengjun
2019-08-13  3:04     ` Steven Rostedt
2019-09-03  8:15       ` Xing Zhengjun
2019-09-04 10:43   ` Steven Rostedt
2019-09-04 13:13     ` Tom Zanussi
2019-09-04 16:59       ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904125923.7b1e66b8@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tom.zanussi@linux.intel.com \
    --cc=zanussi@kernel.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®