From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net
Subject: Re: [PATCH v2 1/2] ethtool: implement Energy Detect Powerdown support via phy-tunable
Date: Wed, 4 Sep 2019 21:53:57 +0200 [thread overview]
Message-ID: <20190904195357.GA21264@lunn.ch> (raw)
In-Reply-To: <20190904162322.17542-2-alexandru.ardelean@analog.com>
On Wed, Sep 04, 2019 at 07:23:21PM +0300, Alexandru Ardelean wrote:
Hi Alexandru
Somewhere we need a comment stating what EDPD means. Here would be a
good place.
> +#define ETHTOOL_PHY_EDPD_DFLT_TX_INTERVAL 0x7fff
> +#define ETHTOOL_PHY_EDPD_NO_TX 0x8000
> +#define ETHTOOL_PHY_EDPD_DISABLE 0
I think you are passing a u16. So why not 0xfffe and 0xffff? We also
need to make it clear what the units are for interval. This file
specifies the contract between the kernel and user space. So we need
to clearly define what we mean here. Lots of comments are better than
no comments.
Andrew
next prev parent reply other threads:[~2019-09-04 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 16:23 [PATCH v2 0/2] " Alexandru Ardelean
2019-09-04 16:23 ` [PATCH v2 1/2] " Alexandru Ardelean
2019-09-04 19:53 ` Andrew Lunn [this message]
2019-09-05 6:25 ` Ardelean, Alexandru
2019-09-05 17:23 ` Florian Fainelli
2019-09-04 16:23 ` [PATCH v2 2/2] net: phy: adin: implement Energy Detect Powerdown mode " Alexandru Ardelean
2019-09-04 20:03 ` Andrew Lunn
2019-09-05 6:32 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904195357.GA21264@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.ardelean@analog.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome