From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F080BC3A5A5 for ; Thu, 5 Sep 2019 10:16:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D41DC2184B for ; Thu, 5 Sep 2019 10:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387828AbfIEKQK (ORCPT ); Thu, 5 Sep 2019 06:16:10 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732834AbfIEKQJ (ORCPT ); Thu, 5 Sep 2019 06:16:09 -0400 Received: from localhost (unknown [89.248.140.11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 86284153878FA; Thu, 5 Sep 2019 03:16:08 -0700 (PDT) Date: Thu, 05 Sep 2019 12:16:07 +0200 (CEST) Message-Id: <20190905.121607.544007284666165538.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152: adjust the settings of ups flags From: David Miller In-Reply-To: <1394712342-15778-327-Taiwan-albertk@realtek.com> References: <1394712342-15778-327-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Sep 2019 03:16:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Wed, 4 Sep 2019 17:34:38 +0800 > The UPS feature only works for runtime suspend, so UPS flags only > need to be set before enabling runtime suspend. Therefore, I create > a struct to record relative information, and use it before runtime > suspend. > > All chips could record such information, even though not all of > them support the feature of UPS. Then, some functions could be > combined. > > Signed-off-by: Hayes Wang This does not apply cleanly to net-next, please respin.