From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0366C43331 for ; Thu, 5 Sep 2019 18:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE1F920870 for ; Thu, 5 Sep 2019 18:57:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NkNLDHA1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387990AbfIES5M (ORCPT ); Thu, 5 Sep 2019 14:57:12 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36763 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387452AbfIES5L (ORCPT ); Thu, 5 Sep 2019 14:57:11 -0400 Received: by mail-pf1-f193.google.com with SMTP id y22so2383790pfr.3 for ; Thu, 05 Sep 2019 11:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/nCAictNnDUt8UpNPme+HYcx2otpA2Cq+yz30/+CpwQ=; b=NkNLDHA1VNhBtMVPNbVO1C5wzS2IJF6G42tikzBj/vtgLee3JtCwOn8nZFRmJd+FV3 HXshvjVtv4qoUM77bzcr0eGqB7H/v6SyJcDIWBp0yXpWyOy8xIvuvXm087A9M3xanwPO 2T9Bf9D7eBPH07y05dBCrUV9mAp6Y6XVc7Qrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/nCAictNnDUt8UpNPme+HYcx2otpA2Cq+yz30/+CpwQ=; b=Tu23E3jstMgmg63lTCR6gZ/9LxZP+Zg7ZXQ/RytbUc+ZmHyqTzx3RkCwGKENY/qWT/ tBK+eCw/aF/LeB8MswnOeVIta0XA7n9HaCERvDRBnepACzNszIMjG29zBFH/fV6Jyert Lf+J5H1il6WzDoJ95gainAenpQT44sirtx6CwRT6SSzReLD3KQyqH2/oQi5izs0s5oi/ fSXEFjFBFvV0geEQSLtubBk0Bn+UtwEjH+JaLkfyCWRwnf/HhBo+KkhFGwqSER1YwmVE /DGsYVCDrmnT9OBLujwnNTdNjuKqu3gHMIRTxKgiDnH2b7I+SmKoAvqgFz8ZWeuYY4MC fhOA== X-Gm-Message-State: APjAAAVQO3AL1JAfuVvFmZ8l4lUAZnddXaM+Eb4njAQOlUhOyZN+mByo jtV8wQZnLFF0vEzTgIOZGX4i4Q== X-Google-Smtp-Source: APXvYqxOhQTVz0pPuDWSAX1OvL95Ohbrj2oEDFudGxtOgutg4YfVTwRb168DYmxy9uq3o36uVT0LKw== X-Received: by 2002:a63:f07:: with SMTP id e7mr4769504pgl.238.1567709831061; Thu, 05 Sep 2019 11:57:11 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id y192sm4868626pfg.141.2019.09.05.11.57.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2019 11:57:10 -0700 (PDT) Date: Thu, 5 Sep 2019 11:57:08 -0700 From: Matthias Kaehlcke To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, Adrian Hunter , Douglas Anderson , Shawn Lin , Jaehoon Chung , Yong Mao , Chaotian Jing , linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/11] mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq() Message-ID: <20190905185708.GB133864@google.com> References: <20190903142207.5825-1-ulf.hansson@linaro.org> <20190903142207.5825-10-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190903142207.5825-10-ulf.hansson@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 04:22:05PM +0200, Ulf Hansson wrote: > The sdhci_ack_sdio_irq() is called only when SDIO IRQs are enabled. > Therefore, let's drop the redundant check of the internal > SDHCI_SDIO_IRQ_ENABLED flag and just re-enable the IRQs immediately. > > Signed-off-by: Ulf Hansson > --- > drivers/mmc/host/sdhci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index c1ebc26846db..2a9be044448a 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2161,8 +2161,7 @@ static void sdhci_ack_sdio_irq(struct mmc_host *mmc) > unsigned long flags; > > spin_lock_irqsave(&host->lock, flags); > - if (host->flags & SDHCI_SDIO_IRQ_ENABLED) > - sdhci_enable_sdio_irq_nolock(host, true); > + sdhci_enable_sdio_irq_nolock(host, true); > spin_unlock_irqrestore(&host->lock, flags); > } FWIW: Reviewed-by: Matthias Kaehlcke