From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: akpm@linux-foundation.org, rcampbell@nvidia.com,
jglisse@redhat.com, mhocko@suse.com, aneesh.kumar@linux.ibm.com,
peterz@infradead.org, airlied@redhat.com, thellstrom@vmware.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory.c: Convert to use vmf_error()
Date: Thu, 5 Sep 2019 11:59:10 -0700 [thread overview]
Message-ID: <20190905185910.GS29434@bombadil.infradead.org> (raw)
In-Reply-To: <1567708980-8804-1-git-send-email-jrdr.linux@gmail.com>
On Fri, Sep 06, 2019 at 12:13:00AM +0530, Souptick Joarder wrote:
> +++ b/mm/memory.c
> @@ -1750,13 +1750,10 @@ static vm_fault_t __vm_insert_mixed(struct vm_area_struct *vma,
> } else {
> return insert_pfn(vma, addr, pfn, pgprot, mkwrite);
> }
> -
> - if (err == -ENOMEM)
> - return VM_FAULT_OOM;
> - if (err < 0 && err != -EBUSY)
> - return VM_FAULT_SIGBUS;
> -
> - return VM_FAULT_NOPAGE;
> + if (!err || err == -EBUSY)
> + return VM_FAULT_NOPAGE;
> + else
> + return vmf_error(err);
> }
My plan is to convert insert_page() to return a VM_FAULT error code like
insert_pfn() does. Need to finish off the vm_insert_page() conversions
first ;-)
next prev parent reply other threads:[~2019-09-05 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 18:43 Souptick Joarder
2019-09-05 18:59 ` Matthew Wilcox [this message]
2019-09-06 12:24 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905185910.GS29434@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=rcampbell@nvidia.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®