From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCDBC43331 for ; Fri, 6 Sep 2019 13:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4112820578 for ; Fri, 6 Sep 2019 13:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405110AbfIFNF2 (ORCPT ); Fri, 6 Sep 2019 09:05:28 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59858 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387851AbfIFNF2 (ORCPT ); Fri, 6 Sep 2019 09:05:28 -0400 Received: from localhost (unknown [88.214.184.128]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7A4E9152F5C9F; Fri, 6 Sep 2019 06:05:26 -0700 (PDT) Date: Fri, 06 Sep 2019 15:05:24 +0200 (CEST) Message-Id: <20190906.150524.1245097015817848153.davem@davemloft.net> To: maowenan@huawei.com Cc: eric.dumazet@gmail.com, tsbogend@alpha.franken.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 net] net: sonic: return NETDEV_TX_OK if failed to map buffer From: David Miller In-Reply-To: <20190905015712.107173-1-maowenan@huawei.com> References: <960c7d1f-6e80-84fb-8d7a-9c5692605500@huawei.com> <20190905015712.107173-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 06 Sep 2019 06:05:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan Date: Thu, 5 Sep 2019 09:57:12 +0800 > NETDEV_TX_BUSY really should only be used by drivers that call > netif_tx_stop_queue() at the wrong moment. If dma_map_single() is > failed to map tx DMA buffer, it might trigger an infinite loop. > This patch use NETDEV_TX_OK instead of NETDEV_TX_BUSY, and change > printk to pr_err_ratelimited. > > Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers") > Signed-off-by: Mao Wenan Applied.