From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292EEC00307 for ; Mon, 9 Sep 2019 06:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71C002067D for ; Mon, 9 Sep 2019 06:14:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=valentin-vidic.from.hr header.i=@valentin-vidic.from.hr header.b="NdYxgthL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727895AbfIIGOG (ORCPT ); Mon, 9 Sep 2019 02:14:06 -0400 Received: from valentin-vidic.from.hr ([94.229.67.141]:53255 "EHLO valentin-vidic.from.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfIIGOG (ORCPT ); Mon, 9 Sep 2019 02:14:06 -0400 X-Virus-Scanned: Debian amavisd-new at valentin-vidic.from.hr Received: by valentin-vidic.from.hr (Postfix, from userid 1000) id ABC2F21B; Mon, 9 Sep 2019 06:14:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=valentin-vidic.from.hr; s=2017; t=1568009640; bh=019Xp0m77GdgTGWg3mqqaF5ta6E621OA5OPgyj1seJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NdYxgthLIh2SuB2tEdFH83Lt0Cz9phFTn5DFigIcBCG5e+rfjcfK4MFNKJeTVUDKK tgsDWMsysBxqhBfqlIZ35lkWrAl4cWaNHMZj5DD0GYpJQhRXJQKL21a7hWCuP0Ve3m 10lmKuChJsHOakHRsIBHgVKyWfSL9ezLVsU/pXFdJYZROMeSGYNzvnmtprJXoNO6yN UxsalzndIYxY7a8caAQY7b/Hl5hUjgT7sBQCZ+faAl5TAs7In0hyLuzx5y00yqBOzm KE7Ie5TSkTO7JPwtUk9SWjRNcqUMYrrP+zsHZ589MV4ooL9PxiquFu32+wt4VV3VvI r+omQcz6d8SNg== Date: Mon, 9 Sep 2019 06:14:00 +0000 From: Valentin =?utf-8?B?VmlkacSH?= To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms Message-ID: <20190909061400.GI7664@valentin-vidic.from.hr> References: <20190908161015.26000-1-vvidic@valentin-vidic.from.hr> <20190908161015.26000-2-vvidic@valentin-vidic.from.hr> <1049678.1567988361@turing-police> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1049678.1567988361@turing-police> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 08, 2019 at 08:19:21PM -0400, Valdis Klētnieks wrote: > In that case, rather than removing it, shouldn't we be *adding* > code to properly set it instead? Right, setting the UtcOffset fields to 0 is the first step marking them as invalid for now. This is also why access_time_ms did not do any harm here - it was always set to 0 too. 7.4.10.2 OffsetValid Field The OffsetValid field shall describe whether the contents of the OffsetFromUtc field are valid or not, as follows: 0, which means the contents of the OffsetFromUtc field are invalid and shall be 00h 1, which means the contents of the OffsetFromUtc field are valid -- Valentin