From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51E7C4740A for ; Mon, 9 Sep 2019 22:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 661C120863 for ; Mon, 9 Sep 2019 22:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Oh/81Sl2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389165AbfIIWgF (ORCPT ); Mon, 9 Sep 2019 18:36:05 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:36388 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfIIWgF (ORCPT ); Mon, 9 Sep 2019 18:36:05 -0400 Received: from pendragon.ideasonboard.com (unknown [88.214.160.167]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 97E3D4FE; Tue, 10 Sep 2019 00:36:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1568068562; bh=ytpDKk/iTXIZzQdXuSLQiM1Plw/tdurNCuOlF0kQUBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oh/81Sl2yegYqXREdFzqny3O9/0MXoaO0hhHQz8Uaf+i1uVY7Hcea6+AOc82SUsr/ 6wDS8y9xBfUdzP8pzfY83cphRhLjI4YfGqyYIjZqo6U99uPv64UjVENczPxqJetUQD D/8XptB8PPpCjvPrnoWa98HtKYrkgF/IpQEm1Qww= Date: Tue, 10 Sep 2019 01:35:56 +0300 From: Laurent Pinchart To: Arnd Bergmann Cc: Jyri Sarha , David Airlie , Daniel Vetter , Sam Ravnborg , Emil Velikov , Tomi Valkeinen , Alexios Zavras , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again Message-ID: <20190909223556.GB15652@pendragon.ideasonboard.com> References: <20190909203409.652308-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190909203409.652308-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thank you for the patch. On Mon, Sep 09, 2019 at 10:33:57PM +0200, Arnd Bergmann wrote: > This was apparently dropped by accident in a recent > cleanup, causing a build failure in some configurations now: > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration] > > Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index 525dc1c0f1c1..9edcdd7f2b96 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include I'd put this before platform_device.h to keep the headers alphabetically ordered. Apart from that, Reviewed-by: Laurent Pinchart > #include > #include -- Regards, Laurent Pinchart