From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 239C7C3A5A2 for ; Tue, 10 Sep 2019 13:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC47920678 for ; Tue, 10 Sep 2019 13:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730229AbfIJNKx (ORCPT ); Tue, 10 Sep 2019 09:10:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38516 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbfIJNKw (ORCPT ); Tue, 10 Sep 2019 09:10:52 -0400 Received: from [148.69.85.38] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1i7fv1-0003ux-A3; Tue, 10 Sep 2019 13:10:51 +0000 Date: Tue, 10 Sep 2019 15:10:50 +0200 From: Christian Brauner To: Oleg Nesterov Cc: Eugene Syromiatnikov , linux-kernel@vger.kernel.org, Christian Brauner , Andrew Morton , "Peter Zijlstra (Intel)" , Ingo Molnar , "Dmitry V. Levin" , Eric Biederman Subject: Re: [PATCH] fork: fail on non-zero higher 32 bits of args.exit_signal Message-ID: <20190910131048.e7xr52az2zej4p4v@wittgenstein> References: <20190910115711.GA3755@asgard.redhat.com> <20190910124440.GA25647@redhat.com> <20190910130935.jxqxbt7wop3ostob@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190910130935.jxqxbt7wop3ostob@wittgenstein> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 03:09:35PM +0200, Christian Brauner wrote: > On Tue, Sep 10, 2019 at 02:44:41PM +0200, Oleg Nesterov wrote: > > On 09/10, Eugene Syromiatnikov wrote: > > > > > > --- a/kernel/fork.c > > > +++ b/kernel/fork.c > > > @@ -2562,6 +2562,9 @@ noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs, > > > if (copy_from_user(&args, uargs, size)) > > > return -EFAULT; > > > > > > + if (unlikely(((unsigned int)args.exit_signal) != args.exit_signal)) > > > + return -EINVAL; > > > > Hmm. Unless I am totally confused you found a serious bug... > > > > Without CLONE_THREAD/CLONE_PARENT copy_process() blindly does > > > > p->exit_signal = args->exit_signal; > > > > the valid_signal(sig) check in do_notify_parent() mostly saves us, but we > > must not allow child->exit_signal < 0, if nothing else this breaks > > thread_group_leader(). > > > > And afaics this patch doesn't fix this? I think we need the valid_signal() > > check... > > Thanks for sending this patch so quickly after our conversation > yesterday, Eugene! > We definitely want valid_signal() to verify the signal is ok. > > Eugene, can you please update the patch to use valid signal and keep it > as a separate patch from the cleanup and selftest patches? I'll then pick this up quickly so we can get this in before 5.3 is out. Thanks! Christian