From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67103C49ED6 for ; Wed, 11 Sep 2019 10:03:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 297DF2075C for ; Wed, 11 Sep 2019 10:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568196196; bh=FjhUgOIGJkgtmIHzYtmQ+p+qD5jls2QKCtwUBxvLqZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eFMGwrFWSAHMZWy7C1pUjhzY/dl3a9xpU6WClaw5hfgXbpYRnMX0UbEroO330OhDF u3X+8QCjmi6MVTTfYQ+MP9NlzSDiEjl/cfCReLRnl9Fpv9s5t7Qa/tLlcZH775uaiX kmUhZrXjOKq2pmpMf9ZSLMcQkXHU0tbRL2t0OudM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbfIKKDP (ORCPT ); Wed, 11 Sep 2019 06:03:15 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:33760 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbfIKKDP (ORCPT ); Wed, 11 Sep 2019 06:03:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=a0Kkj21KsvH+4VqiIM/Zj1XZfe1a49Milh3+Rqzxq0c=; b=Oe3vlnwfQYHbmzzSlu1stRVmc vWirk4HKb/ywIzeJRQYjTKfIQPMP/aAkdDXPaTUVTgtRSMpvr3Yzx3Xpugpe77qC2BpIUz8pcJh8/ BRdmqfi1HirizyKZ/xZiYXIVVHLZf+75AhRCXgpPLg+y0o+dlX13L2cz++BPN1eEuqT6M=; Received: from [148.69.85.38] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i7zSu-0007X1-Kw; Wed, 11 Sep 2019 10:03:08 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id C2AEFD02D76; Wed, 11 Sep 2019 11:03:07 +0100 (BST) Date: Wed, 11 Sep 2019 11:03:07 +0100 From: Mark Brown To: Luhua Xu Cc: Rob Herring , Mark Rutland , Matthias Brugger , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com Subject: Re: [PATCH 3/3] spi: mediatek: support large PA Message-ID: <20190911100307.GR2036@sirena.org.uk> References: <1568195731-3239-1-git-send-email-luhua.xu@mediatek.com> <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="By57YlnFViWR/M0S" Content-Disposition: inline In-Reply-To: <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com> X-Cookie: Be careful! UGLY strikes 9 out of 10! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --By57YlnFViWR/M0S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 11, 2019 at 05:55:31AM -0400, Luhua Xu wrote: > + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(addr_bits)); > + if (ret) > + dev_notice(&pdev->dev, "SPI dma_set_mask(%d) failed, ret:%d\n", > + addr_bits, ret); Not sure why you picked dev_notice() over dev_err() here? Otherwise this looks good so I'll go ahead and apply. --By57YlnFViWR/M0S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl14xlsACgkQJNaLcl1U h9BbAwf/WPyI6V+J0eXXtuhrkDPyjT7RRzxv1xzvLZx1r1SL66BLPAJce+D1yrmY VNBKLZ8pS9tW6rmkDJEQVeeFJ+vQRJGca0DJxgiww9332H2aacH7gkw21eM/Zmi5 b1ziPC3WDTN4LAjDaGmPUq91NcXI3yzc1u+mUAsUEk/3oy/WzrqduSq1K8O2eBhV vAAKEn+rE33sTz2BYQzMx8LbHaflmHYKxqT+HK111Cbq+ecGEOke7ItpZx/zVrFU nJS3vxD35VwGQstEMIMgeXWsNGtD4y+sf2d2T/7DejwYWX9adSmPRdGSkyhCDLBG hWBq3cFtRpYeF/ox+P+R1Zqr+y/J+w== =+5QQ -----END PGP SIGNATURE----- --By57YlnFViWR/M0S--