From: Steven Price <steven.price@arm.com>
To: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation
Date: Thu, 12 Sep 2019 12:28:02 +0100 [thread overview]
Message-ID: <20190912112804.10104-1-steven.price@arm.com> (raw)
The devfreq implementation in panfrost is unnecessarily open coded. It
also tracks utilisation metrics per slot which isn't very useful. Let's
tidy it up!
This should be picked up along with Mark's change[1] to fix
regulator_get_optional() misuse. This also deletes the code changes from
52282163dfa6 and e21dd290881b which would otherwise need reverting, see
the previous discussion[2].
[1] https://lore.kernel.org/lkml/20190904123032.23263-1-broonie@kernel.org/
[2] https://lore.kernel.org/lkml/ccd81530-2dbd-3c02-ca0a-1085b00663b5@arm.com/
Steven Price (2):
drm/panfrost: Use generic code for devfreq
drm/panfrost: Simplify devfreq utilisation tracking
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 126 ++++++--------------
drivers/gpu/drm/panfrost/panfrost_devfreq.h | 3 +-
drivers/gpu/drm/panfrost/panfrost_device.h | 14 +--
drivers/gpu/drm/panfrost/panfrost_job.c | 14 +--
4 files changed, 48 insertions(+), 109 deletions(-)
--
2.20.1
next reply other threads:[~2019-09-12 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 11:28 Steven Price [this message]
2019-09-12 11:28 ` [PATCH 1/2] drm/panfrost: Use generic code for devfreq Steven Price
2019-09-12 11:31 ` Mark Brown
2019-09-12 11:28 ` [PATCH 2/2] drm/panfrost: Simplify devfreq utilisation tracking Steven Price
2019-09-13 17:43 ` Alyssa Rosenzweig
2019-09-16 22:36 ` Rob Herring
2019-09-17 12:18 ` Alyssa Rosenzweig
2019-09-12 14:51 ` [PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912112804.10104-1-steven.price@arm.com \
--to=steven.price@arm.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®