From: Christian Brauner <christian.brauner@ubuntu.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [GIT PULL] clone3 exit signal fix
Date: Thu, 12 Sep 2019 15:40:19 +0200 [thread overview]
Message-ID: <20190912134019.2393-1-christian.brauner@ubuntu.com> (raw)
Hi Linus,
This is a rather urgent last-minute bugfix for clone3() that should go in
before we release 5.3 with clone3().
clone3() did not verify that the exit_signal argument was set to a valid
signal. This can be used to cause a crash by specifying a signal greater
than NSIG. e.g. -1.
The commit from Eugene adds a check to copy_clone_args_from_user() to
verify that the exit signal is limited by CSIGNAL as with legacy clone()
and that the signal is valid. With this we don't get the legacy clone
behavior were an invalid signal could be handed down and would only be
detected and then ignored in do_notify_parent(). Users of clone3() will now
get a proper error right when they pass an invalid exit signal. Note, that
this is not a change in user-visible behavior since no kernel with clone3()
has been released yet.
The following changes since commit f74c2bb98776e2de508f4d607cd519873065118e:
Linux 5.3-rc8 (2019-09-08 13:33:15 -0700)
are available in the Git repository at:
git@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux tags/for-linus-20190912
for you to fetch changes up to a0eb9abd8af92d1aa34bc1e24dfbd1ba0bd6a56c:
fork: block invalid exit signals with clone3() (2019-09-12 14:56:33 +0200)
Please consider pulling these changes from the signed for-linus-20190912 tag.
Thanks!
Christian
----------------------------------------------------------------
for-linus-20190912
----------------------------------------------------------------
Eugene Syromiatnikov (1):
fork: block invalid exit signals with clone3()
kernel/fork.c | 10 ++++++++++
1 file changed, 10 insertions(+)
next reply other threads:[~2019-09-12 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 13:40 Christian Brauner [this message]
2019-09-12 14:05 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912134019.2393-1-christian.brauner@ubuntu.com \
--to=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®