From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gareth Williams <gareth.williams.jx@renesas.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] spi: dw: Add compatible string for Renesas RZ/N1 SPI Controller
Date: Sun, 15 Sep 2019 12:22:42 +0100 [thread overview]
Message-ID: <20190915112242.GA43855@sirena.co.uk> (raw)
In-Reply-To: <CAHp75VeJY44oqYPhb-E8U1Uz5tKEJ1wZfmsGYEDttLzypHEAHA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Sun, Sep 15, 2019 at 02:00:33PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2019 at 3:14 PM Gareth Williams
> > The Renesas RZ/N1 SPI Controller is based on the Synopsys DW SSI, but has
> > additional registers for software CS control and DMA. This patch does not
> > address the changes required for DMA support, it simply adds the compatible
> > string. The CS registers are not needed as Linux can use gpios for the CS
> > signals.
> > + { .compatible = "renesas,rzn1-spi", },
> Can't you simple use in DT something like
> compatible = "renesas,rzn1-spi", "snps,dw-apb-ssi"
> ?
Yes, you can and should do that but it's still nice to list the
compatibles explicitly in the driver in case someone leaves out the
fallback compatible for whatever reason - if both the driver and the DT
list things then there's a bit more robustness.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-09-15 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:11 [PATCH 0/3] spi: dw: Add basic runtime PM support Gareth Williams
2019-09-13 12:11 ` [PATCH 1/3] dt: spi: Add Renesas RZ/N1 binding documentation Gareth Williams
2019-09-13 12:11 ` [PATCH 2/3] spi: dw: Add basic runtime PM support Gareth Williams
2019-09-16 14:36 ` Geert Uytterhoeven
2019-09-16 16:14 ` Gareth Williams
2019-09-17 6:36 ` Geert Uytterhoeven
2019-09-17 9:34 ` Gareth Williams
2019-09-13 12:12 ` [PATCH 3/3] spi: dw: Add compatible string for Renesas RZ/N1 SPI Controller Gareth Williams
2019-09-15 11:00 ` Andy Shevchenko
2019-09-15 11:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915112242.GA43855@sirena.co.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gareth.williams.jx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®