From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9EACC4CECD for ; Tue, 17 Sep 2019 09:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74BF22067B for ; Tue, 17 Sep 2019 09:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=aurabindo.in header.i=@aurabindo.in header.b="eQjSy21K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbfIQJMZ (ORCPT ); Tue, 17 Sep 2019 05:12:25 -0400 Received: from mail4.protonmail.ch ([185.70.40.27]:20970 "EHLO mail4.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfIQJMZ (ORCPT ); Tue, 17 Sep 2019 05:12:25 -0400 Date: Tue, 17 Sep 2019 09:12:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aurabindo.in; s=protonmail; t=1568711541; bh=ZKYIzKdgRRtrB7OyOmWDzTMGg6uay9ipjlu1WQonyTU=; h=Date:To:From:Cc:Reply-To:Subject:Feedback-ID:From; b=eQjSy21KM5OSXxxHfL1Q0qHO98l3ynqXu8fnUA4rHJu0AHrC6MQbLJr3PyVby+VLd HftIbwWlow6/FRq+UwbpO4l5ArWqYTCd+B5WEmp/Ozjw7Y/szu+/yOmVBRq/qx4u4A NkAgdHx082bP+SO2K8f2zMj/58ejxv+TrWH7LCa4= To: broonie@kernel.org, palmer@sifive.com, paul.walmsley@sifive.com From: Aurabindo Jayamohanan Cc: linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Reply-To: Aurabindo Jayamohanan Subject: [PATCH] spi: sifive: check return value for platform_get_resource() Message-ID: <20190917091207.4925-1-mail@aurabindo.in> Feedback-ID: D1Wwva8zb0UdpJtanaReRLGO3iCsewpGmDn8ZDKmpao-Gnxd2qXPmwwrSQ99r5Q15lmK-D8x6vKzqhUKCgzweA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_resource() may return NULL. If it is so, return -ENXIO Signed-off-by: Aurabindo Jayamohanan --- drivers/spi/spi-sifive.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c index 93ec2c6cdbfd..67485067a694 100644 --- a/drivers/spi/spi-sifive.c +++ b/drivers/spi/spi-sifive.c @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device *pd= ev) =09platform_set_drvdata(pdev, master); =20 =09res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); +=09if (!res) { +=09=09dev_err(&pdev->dev, "no IOMEM resource found\n"); +=09=09ret =3D -ENXIO; +=09=09goto put_master; +=09} + =09spi->regs =3D devm_ioremap_resource(&pdev->dev, res); =09if (IS_ERR(spi->regs)) { =09=09ret =3D PTR_ERR(spi->regs); --=20 2.23.0