Hi,

On Fri, May 04, 2018 at 09:44:25AM +0200, Rasmus Villemoes wrote:
> >> +static int
> >> +ls_extirq_set_type(struct irq_data *data, unsigned int type)
> >> +{
> >> +	irq_hw_number_t hwirq = data->hwirq;
> >> +	struct extirq_chip_data *chip_data = data->chip_data;
> >> +	u32 value, mask;
> >
> > Please order local variables in reverse fir tree fashion whenever
> > possible. That's way simpler to read:
> >
> > 	struct extirq_chip_data *chip_data = data->chip_data;
> > 	irq_hw_number_t hwirq = data->hwirq;
> > 	u32 value, mask;
>
> Fixed, thanks.

Did you send a sixth version of this patch set? It seems like the code
hasn't been merged, yet. I also need support for the external interrupt
lines on a different Layerscape.

Thanks,
Kurt