From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E0DC4CECD for ; Tue, 17 Sep 2019 09:41:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81C0F20862 for ; Tue, 17 Sep 2019 09:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbfIQJlw (ORCPT ); Tue, 17 Sep 2019 05:41:52 -0400 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:59521 "EHLO esa1.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbfIQJlw (ORCPT ); Tue, 17 Sep 2019 05:41:52 -0400 IronPort-SDR: S/2BoUMvGFoMuNLWaaxaR3Z/rrCThOn02QPpez5DVcRn6HHoNfSTYEVDH9kl3OPS+yj3OBZtgU lYYG5v7y4phQF+vIaNPnEOOZOr3zYNDVvB0Hj7/nT4k8VcDw+VSN58aaqBWS91iut0fU0opdvS DELnrDjD5VOPyOBl5HVMIFl+P1kc+LiHcWXSe4KxGkaq25CfU43yNFQZbKeovKYPXAyQBBtz9F h4orcRVOiIDrZFk3bR9E+Sk5pS+TsSseGjcxO/TnUQsCZIb2zy/YjoAOqWNETO/LI7E6IRj/K7 tKc= X-IronPort-AV: E=Sophos;i="5.64,515,1559548800"; d="scan'208";a="43223200" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 17 Sep 2019 01:41:51 -0800 IronPort-SDR: rFfvGxdoeiV7Af0Kjqe+ephBZFvYLx+QNORmL/+6EUNouKSyjbAKBdLRAk9Spk0OYfT3ng8YPa TT+UuKYTImreUD9cUkTsWOG9ekrvZGCVqSVo5h6jiaDXqLqcrGZRcpfbpuvsMDnQMWSo6vSeuU IJvBN8NRoMXFdTMX1kMF8NVkhueGU7YMvC+DjaHMn8BDSlMvpDPwFmZz4KAeqpt3+D9afOMasA LeACRw1aCe9ECtBOQ44GPipy+qV6SDD93r0Yh7HAZ50+Kp8MMSTXedGDCsHENoh17vUfKz/4ri yMo= From: Jiada Wang To: , , , , CC: , , Subject: [PATCH v3 34/49] input: atmel_mxt_ts: export GPIO reset line via sysfs Date: Tue, 17 Sep 2019 18:41:22 +0900 Message-ID: <20190917094137.18851-1-jiada_wang@mentor.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "George G. Davis" N.B. Modifying the atmel_mxt_ts GPIO reset line during operation will cause problems with normal driver operation. This feature is provided as a diagnostic debug aid. It does not take into consideration any pending operations which may be in progress. Modifying the atmel_mxt_ts GPIO reset line at any time will inevitably cause the driver to fail. Signed-off-by: George G. Davis Signed-off-by: Rajeev Kumar Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index bdc5088baea8..4670880e52a2 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -4086,6 +4086,19 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) return error; } + if (data->reset_gpio) { + error = gpiod_export(data->reset_gpio, 0); + if (error) + return error; + + error = gpiod_export_link(&client->dev, "reset", + data->reset_gpio); + if (error) { + gpiod_unexport(data->reset_gpio); + return error; + } + } + if (data->suspend_mode == MXT_SUSPEND_REGULATOR) { error = mxt_acquire_irq(data); if (error) @@ -4118,6 +4131,10 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id) err_free_object: mxt_free_input_device(data); mxt_free_object_table(data); + if (data->reset_gpio) { + sysfs_remove_link(&client->dev.kobj, "reset"); + gpiod_unexport(data->reset_gpio); + } return error; } @@ -4127,6 +4144,10 @@ static int mxt_remove(struct i2c_client *client) disable_irq(data->irq); sysfs_remove_group(&client->dev.kobj, &mxt_fw_attr_group); + if (data->reset_gpio) { + sysfs_remove_link(&client->dev.kobj, "reset"); + gpiod_unexport(data->reset_gpio); + } mxt_debug_msg_remove(data); mxt_sysfs_remove(data); mxt_free_input_device(data); -- 2.19.2