From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+2f807f4d3a2a4e87f18f@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
mingo@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: general protection fault in trace_probe_unlink
Date: Tue, 17 Sep 2019 21:13:59 -0400 [thread overview]
Message-ID: <20190917211359.0407a222@oasis.local.home> (raw)
In-Reply-To: <20190917031342.7248-1-hdanton@sina.com>
On Tue, 17 Sep 2019 11:13:42 +0800
Hillf Danton <hdanton@sina.com> wrote:
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -986,6 +986,9 @@ int trace_probe_init(struct trace_probe
> if (!tp->event)
> return -ENOMEM;
>
> + /* shun gpf in error cleanup path */
> + INIT_LIST_HEAD(&tp->list);
Thanks, but I took Masami's patch.
https://lore.kernel.org/lkml/156869709721.22406.5153754822203046939.stgit@devnote2/
-- Steve
> +
> call = trace_probe_event_call(tp);
> call->class = &tp->event->class;
> call->name = kstrdup(event, GFP_KERNEL);
> @@ -1002,7 +1005,6 @@ int trace_probe_init(struct trace_probe
> INIT_LIST_HEAD(&tp->event->files);
> INIT_LIST_HEAD(&tp->event->class.fields);
> INIT_LIST_HEAD(&tp->event->probes);
> - INIT_LIST_HEAD(&tp->list);
> list_add(&tp->event->probes, &tp->list);
>
> return 0;
> --
next parent reply other threads:[~2019-09-18 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190917031342.7248-1-hdanton@sina.com>
2019-09-18 1:13 ` Steven Rostedt [this message]
2019-09-16 23:39 syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917211359.0407a222@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=syzbot+2f807f4d3a2a4e87f18f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®