From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: navid.emamdoost@gmail.com, andrew@lunn.ch, emamd001@umn.edu,
smccaman@umn.edu, kjlu@umn.edu, vivien.didelot@gmail.com,
f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: sja1105: prevent leaking memory
Date: Thu, 19 Sep 2019 10:10:59 +0200 (CEST) [thread overview]
Message-ID: <20190919.101059.1330167782179062709.davem@davemloft.net> (raw)
In-Reply-To: <8d6f6c54-1758-7d98-c9b5-5c16b171c885@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Wed, 18 Sep 2019 23:00:20 +0300
> Hi Navid,
>
> Thanks for the patch.
>
> On 9/18/19 9:04 PM, Navid Emamdoost wrote:
>> In sja1105_static_config_upload, in two cases memory is leaked: when
>> static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx
>> fails. In both cases config_buf should be released.
>> Fixes: 8aa9ebccae876 (avoid leaking config_buf)
>> Fixes: 1a4c69406cc1c (avoid leaking config_buf)
>>
>
> You're not supposed to add a short description of the patch here, but
> rather the commit message of the patch you're fixing.
> Add this to your ~/.gitconfig:
>
> [pretty]
> fixes = Fixes: %h (\"%s\")
>
> And then run:
> git show --pretty=fixes 8aa9ebccae87621d997707e4f25e53fddd7e30e4
>
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105
> 5-port L2 switch")
>
> git show --pretty=fixes 1a4c69406cc1c3c42bb7391c8eb544e93fe9b320
>
> Fixes: 1a4c69406cc1 ("net: dsa: sja1105: Prevent PHY jabbering during
> switch reset")
However the Fixes: line should not be broken up like this with newlines.
next prev parent reply other threads:[~2019-09-19 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 17:10 [PATCH] " Navid Emamdoost
2019-09-18 17:21 ` Andrew Lunn
2019-09-18 18:04 ` [PATCH v2] " Navid Emamdoost
2019-09-18 20:00 ` Vladimir Oltean
2019-09-18 20:34 ` [PATCH v3] " Navid Emamdoost
2019-09-18 20:40 ` Vladimir Oltean
2019-09-19 8:13 ` David Miller
2019-09-19 8:10 ` David Miller [this message]
2019-09-19 8:20 ` [PATCH v2] " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919.101059.1330167782179062709.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=emamd001@umn.edu \
--cc=f.fainelli@gmail.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=smccaman@umn.edu \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®