From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570DCC4360D for ; Sat, 21 Sep 2019 19:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32A2D2196E for ; Sat, 21 Sep 2019 19:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732362AbfIUTHN (ORCPT ); Sat, 21 Sep 2019 15:07:13 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:60584 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbfIUTHN (ORCPT ); Sat, 21 Sep 2019 15:07:13 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8458B2002D; Sat, 21 Sep 2019 21:07:09 +0200 (CEST) Date: Sat, 21 Sep 2019 21:07:08 +0200 From: Sam Ravnborg To: Adam Ford Cc: dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, adam.ford@logicpd.com, Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel Message-ID: <20190921190708.GB32133@ravnborg.org> References: <20190917161214.2913-1-aford173@gmail.com> <20190917161214.2913-2-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190917161214.2913-2-aford173@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=TaQvIJAheEgyp50s76YA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adam. Good with even more panels. But for new bindings please use meta-schema (.yaml) format. This is what we use for new bindings as it allows better validation. Sam On Tue, Sep 17, 2019 at 11:12:12AM -0500, Adam Ford wrote: > This patch adds documentation of device tree bindings for the WVGA panel > Logic PD Type 28 display. > > Signed-off-by: Adam Ford > > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt > new file mode 100644 > index 000000000000..829fc5210e06 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt > @@ -0,0 +1,26 @@ > +Logic PD Type 28 4.3" WQVGA TFT LCD panel > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > + > +Required properties: > +- compatible: should be "logicpd,type28" > + > +Optional properties: > +- power-supply: regulator to provide the supply voltage > +- enable-gpios: GPIO pin to enable or disable the panel > +- backlight: phandle of the backlight device attached to the panel Is it correct that these are optional for the descrivbed panel? > + > +Optional nodes: > +- Video port for RGB input. > + > +Example: > + lcd0: display { > + compatible = "logicpd,type28"; > + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; > + port { > + lcd_in: endpoint { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + }; > -- > 2.17.1