From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC270C3A5A2 for ; Sun, 22 Sep 2019 19:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A865420882 for ; Sun, 22 Sep 2019 19:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569179500; bh=e0OsJVXdRup6T509mAuK/fbZ1RieDXJfxSYWGYLNNhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BqdjDO4jCCqJh4TR3aYvib9fNQrUvsrskcL8FzYXt11JImheAoNQ7Np3RLXtJYxcG B7yN66KtOqUZ8at9+yT6Jc7kKWypL1jx3yE/oLGZnicg5+oK9lrEtOgLRsOSGCQv0z 6+eSZ0HunMZl81vqLf5K/8FEa2nnXcIswAEk5XMM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395564AbfIVTLj (ORCPT ); Sun, 22 Sep 2019 15:11:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:32986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405384AbfIVS6Z (ORCPT ); Sun, 22 Sep 2019 14:58:25 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C69A5214D9; Sun, 22 Sep 2019 18:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178704; bh=e0OsJVXdRup6T509mAuK/fbZ1RieDXJfxSYWGYLNNhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=demiMWVPDGRTmIK+BV/5+F9+utXXhko6Zs811kmTnZT8U8EU0ic69E9Vt/p58E62v imD7BjlHzElxS7lZFC0D3wXEanRq+eIPFeV+06YX/eCnjJMt2N/ohCOVd1gEHs7Azl jchGCDgEf5rspWlf48iayAoQIMMPNLuYGWfijEL8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 41/89] media: omap3isp: Don't set streaming state on random subdevs Date: Sun, 22 Sep 2019 14:56:29 -0400 Message-Id: <20190922185717.3412-41-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922185717.3412-1-sashal@kernel.org> References: <20190922185717.3412-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] The streaming state should be set to the first upstream sub-device only, not everywhere, for a sub-device driver itself knows how to best control the streaming state of its own upstream sub-devices. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/omap3isp/isp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index c834fea5f9b00..b34b6a604f92f 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -727,6 +727,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe, s_stream, mode); pipe->do_propagation = true; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return 0; @@ -841,6 +845,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe) &subdev->entity); failure = -ETIMEDOUT; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return failure; -- 2.20.1