From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 323B7C432C2 for ; Tue, 24 Sep 2019 13:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 086772064A for ; Tue, 24 Sep 2019 13:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2632747AbfIXNaO (ORCPT ); Tue, 24 Sep 2019 09:30:14 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51550 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504934AbfIXNaO (ORCPT ); Tue, 24 Sep 2019 09:30:14 -0400 Received: from localhost (231-157-167-83.reverse.alphalink.fr [83.167.157.231]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 97DB915248DA9; Tue, 24 Sep 2019 06:30:12 -0700 (PDT) Date: Tue, 24 Sep 2019 15:30:08 +0200 (CEST) Message-Id: <20190924.153008.1663682877890370513.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule From: David Miller In-Reply-To: References: <20190924073615.31704-1-Jason@zx2c4.com> <20190924.145257.2013712373872209531.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Sep 2019 06:30:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 14:55:04 +0200 > On Tue, Sep 24, 2019 at 2:53 PM David Miller wrote: >> Please make such test cases integratabe into the selftests area for networking >> and submit it along with this fix. > > That link is for a WireGuard test-case. When we get that upstream, > those will all live in selftests/ all the same as you'd like. For now, > it's running for every kernel on https://build.wireguard.com/ which in > turn runs for every new commit. I'm asking you to make a non-wireguard test that triggers the problem. Or would you like a situation you're interested in to break from time to time. Jason, please don't be difficult about this and write a proper test case just like I would ask anyone else fixing bugs like this to write. Thank you.