From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD4DC432C1 for ; Tue, 24 Sep 2019 07:38:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65934214D9 for ; Tue, 24 Sep 2019 07:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502861AbfIXHif (ORCPT ); Tue, 24 Sep 2019 03:38:35 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38148 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388489AbfIXHif (ORCPT ); Tue, 24 Sep 2019 03:38:35 -0400 Received: from [185.81.136.22] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iCfOv-0004Up-Tc; Tue, 24 Sep 2019 07:38:22 +0000 Date: Tue, 24 Sep 2019 09:38:18 +0200 From: Christian Brauner To: Florian Weimer Cc: "Michael Kerrisk (man-pages)" , Jann Horn , Daniel Colascione , "Eric W. Biederman" , Joel Fernandes , Linux API , lkml , linux-man , Oleg Nesterov Subject: Re: For review: pidfd_open(2) manual page Message-ID: <20190924073817.zb7vr5he4wbibl7j@wittgenstein> References: <90399dee-53d8-a82c-3871-9ec8f94601ce@gmail.com> <87tv939td6.fsf@mid.deneb.enyo.de> <63566f1f-667d-50ca-ae85-784924d09af4@gmail.com> <874l12924w.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874l12924w.fsf@mid.deneb.enyo.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:41:19PM +0200, Florian Weimer wrote: > * Michael Kerrisk: > > >>> static > >>> int pidfd_open(pid_t pid, unsigned int flags) > >>> { > >>> return syscall(__NR_pidfd_open, pid, flags); > >>> } > >> > >> Please call this function something else (not pidfd_open), so that the > >> example continues to work if glibc provides the system call wrapper. > > > > I figured that if the syscall does get added to glibc, then I would > > modify the example. In the meantime, this does seem the most natural > > way of doing things, since the example then uses the real syscall > > name as it would be used if there were a wrapper function. > > The problem is that programs do this as well, so they fail to build > once they are built on a newer glibc version. > > > But, this leads to the question: what do you think the likelihood > > is that this system call will land in glibc? > > Quite likely. It's easy enough to document, there are no P&C issues, > and it doesn't need any new types. My previous mail probably didn't make it so here it is again: I think especially with the recently established glibc consensus to provide wrappers for all new system calls (with some sensible exceptions) I'd expect this to be the case. > > pidfd_send_signal is slightly more difficult because we probably need > to add rt_sigqueueinfo first, for consistency. Oh, huh. Somehow I thought we already provide that. Christian