From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Alastair D'Silva <alastair@d-silva.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Dan Williams <dan.j.williams@intel.com>,
Wei Yang <richard.weiyang@gmail.com>, Qian Cai <cai@lca.pw>,
Jason Gunthorpe <jgg@ziepe.ca>,
Logan Gunthorpe <logang@deltatee.com>,
Ira Weiny <ira.weiny@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] memory_hotplug: Add a bounds check to check_hotplug_memory_range()
Date: Tue, 24 Sep 2019 13:45:03 +0200 [thread overview]
Message-ID: <20190924114503.GK23050@dhcp22.suse.cz> (raw)
In-Reply-To: <32531671-77dd-7857-f34f-f73ea45f7e22@redhat.com>
On Tue 24-09-19 11:13:31, David Hildenbrand wrote:
> On 24.09.19 11:09, Michal Hocko wrote:
> > On Tue 24-09-19 11:31:05, Alastair D'Silva wrote:
> >> On Mon, 2019-09-23 at 14:25 +0200, Michal Hocko wrote:
[...]
> >>> This will result in a silent failure (unlike misaligned case). Is
> >>> this
> >>> what we want?
> >>
> >> Good point - I guess it comes down to, is there anything we expect an
> >> end user to do about it? I'm not sure there is, in which case the bad
> >> RC, which is reported up every call chain that I can see, should be
> >> sufficient.
> >
> > It seems like a clear HW/platform bug to me. And that should better be
> > reported loudly to the log to make sure people do complain to their FW
> > friends and have it fixed.
> >
>
> I don't agree in virtual environment. On s390x, MAX_PHYSMEM_BITS is
> configurable. For example, if you have paravirtualized memory hotplug
> (e.g., virtio-mem), you could add memory to the system that violates
> this constraint.
What happens if that is the case. Does the machine change the
configuration in runtime or it needs a reboot?
Anyway, seeing this to be the case in the log would help in whatever
action is necessary to deal with the issue, right?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-09-24 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 1:07 [PATCH v3 0/2] Add bounds check for Hotplugged memory Alastair D'Silva
2019-09-17 1:07 ` [PATCH v3 1/2] memory_hotplug: Add a bounds check to check_hotplug_memory_range() Alastair D'Silva
2019-09-17 7:26 ` David Hildenbrand
2019-09-23 12:25 ` Michal Hocko
2019-09-24 1:31 ` Alastair D'Silva
2019-09-24 9:09 ` Michal Hocko
2019-09-24 9:13 ` David Hildenbrand
2019-09-24 11:45 ` Michal Hocko [this message]
2019-09-17 1:07 ` [PATCH v3 2/2] mm: Add a bounds check in devm_memremap_pages() Alastair D'Silva
2019-09-17 7:27 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924114503.GK23050@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alastair@d-silva.org \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=osalvador@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®