From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1728C432C2 for ; Tue, 24 Sep 2019 14:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B79D214DA for ; Tue, 24 Sep 2019 14:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569335026; bh=FrA87LWEkHFpDtzfvS/j9/FYFebkYs8YTEUFzDOSYtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AJVaG3Tzi2JutnTe9K2leohBE0BEP6YhQg9wsxpZxZM7itZe6sMBRvoWtJIA1l3Ai LCK5/F9sglEtyrurpe56ANNo+PZAXR6OUArNW36vkpG4ptB0rGW3MjWz3jxXWGy9oS W8OUDRzK0j9saVytwuQnH/I67XyOZ1WVkQq3eLSo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437062AbfIXOXp (ORCPT ); Tue, 24 Sep 2019 10:23:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:37518 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389459AbfIXOXp (ORCPT ); Tue, 24 Sep 2019 10:23:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5AB60AC84; Tue, 24 Sep 2019 14:23:43 +0000 (UTC) Date: Tue, 24 Sep 2019 16:23:42 +0200 From: Michal Hocko To: Alexander Duyck Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, mst@redhat.com, david@redhat.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, vbabka@suse.cz, akpm@linux-foundation.org, mgorman@techsingularity.net, linux-arm-kernel@lists.infradead.org, osalvador@suse.de, yang.zhang.wz@gmail.com, pagupta@redhat.com, konrad.wilk@oracle.com, nitesh@redhat.com, riel@surriel.com, lcapitulino@redhat.com, wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com Subject: Re: [PATCH v10 0/6] mm / virtio: Provide support for unused page reporting Message-ID: <20190924142342.GX23050@dhcp22.suse.cz> References: <20190918175109.23474.67039.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918175109.23474.67039.stgit@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 18-09-19 10:52:25, Alexander Duyck wrote: [...] > In order to try and keep the time needed to find a non-reported page to > a minimum we maintain a "reported_boundary" pointer. This pointer is used > by the get_unreported_pages iterator to determine at what point it should > resume searching for non-reported pages. In order to guarantee pages do > not get past the scan I have modified add_to_free_list_tail so that it > will not insert pages behind the reported_boundary. > > If another process needs to perform a massive manipulation of the free > list, such as compaction, it can either reset a given individual boundary > which will push the boundary back to the list_head, or it can clear the > bit indicating the zone is actively processing which will result in the > reporting process resetting all of the boundaries for a given zone. Is this any different from the previous version? The last review feedback (both from me and Mel) was that we are not happy to have an externally imposed constrains on how the page allocator is supposed to maintain its free lists. If this is really the only way to go forward then I would like to hear very convincing arguments about other approaches not being feasible. There are none in this cover letter unfortunately. This will be really a hard sell without them. -- Michal Hocko SUSE Labs