From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC81C432C2 for ; Wed, 25 Sep 2019 16:47:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9535E20673 for ; Wed, 25 Sep 2019 16:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569430046; bh=qZWh1l9418udA2duAnzDVqksWcn7F7/KPGsUdcOLjvE=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=Pnd1SAge3Noq+PZN1bN5bszqs2calVmtJDUWxnv5RVhvPimDoB7If16ckwKd36kdN BhKb2Tny4hDOWDNl03SFpUdBmUjthntoU1x1A4VI8w9MZyA7n+Q5HPshZKVKkQcEud rWpGvChBxNagi50G+C/gErlsc1sIf/LgLUUfiWZo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392137AbfIYQrZ (ORCPT ); Wed, 25 Sep 2019 12:47:25 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35814 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392099AbfIYQrY (ORCPT ); Wed, 25 Sep 2019 12:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=SldDdMCvb42kOlw4xzQW7gVTJLjho+01MgP87kKdXpk=; b=axofkkkgudCy wW1h64JlpzlwI9A+1kf4uxowV0hE6LS4aZnPVwdGiz26DHaspPObyClnZmIt5pwQJTpM9vDkQyx+y 8UyIzr92Z8lcASQSvjiu//j5k/5PvvyP5cycd+QFa5SKEKyxpMhrCeQaPHCfFIdIxLFEmRZI/4Bcy 7liZ0=; Received: from [12.157.10.118] (helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iDARf-0007uX-Ka; Wed, 25 Sep 2019 16:47:15 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 18588D01BD1; Wed, 25 Sep 2019 17:47:14 +0100 (BST) From: Mark Brown To: Lukasz Majewski Cc: kbuild test robot , krzk@kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown Subject: Applied "spi: Add call to spi_slave_abort() function when spidev driver is released" to the spi tree In-Reply-To: <20190925091143.15468-2-lukma@denx.de> X-Patchwork-Hint: ignore Message-Id: <20190925164714.18588D01BD1@fitzroy.sirena.org.uk> Date: Wed, 25 Sep 2019 17:47:14 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: Add call to spi_slave_abort() function when spidev driver is released has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 9f918a728cf86b2757b6a7025e1f46824bfe3155 Mon Sep 17 00:00:00 2001 From: Lukasz Majewski Date: Wed, 25 Sep 2019 11:11:42 +0200 Subject: [PATCH] spi: Add call to spi_slave_abort() function when spidev driver is released This change is necessary for spidev devices (e.g. /dev/spidev3.0) working in the slave mode (like NXP's dspi driver for Vybrid SoC). When SPI HW works in this mode - the master is responsible for providing CS and CLK signals. However, when some fault happens - like for example distortion on SPI lines - the SPI Linux driver needs a chance to recover from this abnormal situation and prepare itself for next (correct) transmission. This change doesn't pose any threat on drivers working in master mode as spi_slave_abort() function checks if SPI slave mode is supported. Signed-off-by: Lukasz Majewski Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de Signed-off-by: Mark Brown Reported-by: kbuild test robot Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de Signed-off-by: Mark Brown --- drivers/spi/spidev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 255786f2e844..3ea9d8a3e6e8 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -627,6 +627,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0; -- 2.20.1