From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F13C4360C for ; Fri, 27 Sep 2019 18:12:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F247A207FF for ; Fri, 27 Sep 2019 18:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbfI0SM6 (ORCPT ); Fri, 27 Sep 2019 14:12:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35050 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbfI0SM5 (ORCPT ); Fri, 27 Sep 2019 14:12:57 -0400 Received: from localhost (231-157-167-83.reverse.alphalink.fr [83.167.157.231]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 648AA153E82D5; Fri, 27 Sep 2019 11:12:55 -0700 (PDT) Date: Fri, 27 Sep 2019 20:12:54 +0200 (CEST) Message-Id: <20190927.201254.1845107055780234974.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, jakub.kicinski@netronome.com, john.hurley@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, frederik.lotter@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs From: David Miller In-Reply-To: <20190925190512.3404-1-navid.emamdoost@gmail.com> References: <20190925190512.3404-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Sep 2019 11:12:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Wed, 25 Sep 2019 14:05:09 -0500 > In nfp_flower_spawn_vnic_reprs in the loop if initialization or the > allocations fail memory is leaked. Appropriate releases are added. > > Signed-off-by: Navid Emamdoost Applied.